From 791c218b48b6557f24d479a7aa7d6586a612a128 Mon Sep 17 00:00:00 2001 From: Rosen Penev Date: Tue, 10 Dec 2019 20:46:02 -0800 Subject: Fix unnecessary double promotion Found with -Wdouble-promotion and -Wfloat-equal --- src/common.c | 4 ++-- src/download.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/common.c b/src/common.c index 325ea2d..a1bfd09 100644 --- a/src/common.c +++ b/src/common.c @@ -245,7 +245,7 @@ void print_progress_bar(double progress) { else info(" "); } info("] %5.1f%%", progress); - if(progress == 100) info("\n"); + if(progress >= 100) info("\n"); fflush((info_stream) ? info_stream : stdout); #endif } @@ -469,7 +469,7 @@ void idevicerestore_progress(struct idevicerestore_client_t* client, int step, d } else { // we don't want to be too verbose in regular idevicerestore. if ((step == RESTORE_STEP_UPLOAD_FS) || (step == RESTORE_STEP_VERIFY_FS) || (step == RESTORE_STEP_FLASH_FW)) { - print_progress_bar(100.0f * progress); + print_progress_bar(100.0 * progress); } } } diff --git a/src/download.c b/src/download.c index 2194091..a258da2 100644 --- a/src/download.c +++ b/src/download.c @@ -92,7 +92,7 @@ static int download_progress(void *clientp, double dltotal, double dlnow, double { double p = (dlnow / dltotal) * 100; - if (p < 100.0f) { + if (p < 100.0) { if ((int)p > lastprogress) { info("downloading: %d%%\n", (int)p); lastprogress = (int)p; -- cgit v1.1-32-gdbae