From e314faac7850ebe9076b7cf5807f87ae6bd122fa Mon Sep 17 00:00:00 2001 From: Nikias Bassen Date: Fri, 10 Nov 2023 03:38:42 +0000 Subject: opack: Fixed 32bit buffer overflow Thanks to @cornejo for spotting this! --- src/opack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/opack.c b/src/opack.c index 9e7fa73..8892c26 100644 --- a/src/opack.c +++ b/src/opack.c @@ -206,7 +206,7 @@ static void opack_encode_node(plist_t node, struct char_buf* cbuf) if (len >> 32) { uint8_t blen = 0x94; char_buf_append(cbuf, 1, &blen); - uint32_t u64val = htole64(len); + uint64_t u64val = htole64(len); char_buf_append(cbuf, 8, (unsigned char*)&u64val); } else { uint8_t blen = 0x93; -- cgit v1.1-32-gdbae