Convert int16_t macro error types into enum to improve debugging/type-checking

This simple change provides various benefits for developers like compile
time errors, better auto-completition in editors and the ability of a
debugger to show the constant instead of just the raw value.
Thanks to Aaron Burghardt for the proposal.

1 files changed, 9 insertions, 12 deletions

diff --git a/include/libimobiledevice/debugserver.h b/include/libimobiledevice/debugserver.h
index aa62746..3b1969a 100644
--- a/include/libimobiledevice/debugserver.h
+++ b/include/libimobiledevice/debugserver.h
@@ -32,18 +32,15 @@ extern "C" {
 
 #define DEBUGSERVER_SERVICE_NAME "com.apple.debugserver"
 
-/** @name Error Codes */
-/*@{*/
-#define DEBUGSERVER_E_SUCCESS                0
-#define DEBUGSERVER_E_INVALID_ARG           -1
-#define DEBUGSERVER_E_MUX_ERROR             -2
-#define DEBUGSERVER_E_SSL_ERROR             -3
-#define DEBUGSERVER_E_RESPONSE_ERROR        -4
-#define DEBUGSERVER_E_UNKNOWN_ERROR       -256
-/*@}*/
-
-/** Represents an error code. */
-typedef int16_t debugserver_error_t;
+/** Error Codes */
+typedef enum {
+        DEBUGSERVER_E_SUCCESS        =  0,
+        DEBUGSERVER_E_INVALID_ARG    = -1,
+        DEBUGSERVER_E_MUX_ERROR      = -2,
+        DEBUGSERVER_E_SSL_ERROR      = -3,
+        DEBUGSERVER_E_RESPONSE_ERROR = -4,
+        DEBUGSERVER_E_UNKNOWN_ERROR  = -256
+} debugserver_error_t;
 
 typedef struct debugserver_client_private debugserver_client_private;
 typedef debugserver_client_private *debugserver_client_t; /**< The client handle. */