Convert int16_t macro error types into enum to improve debugging/type-checking

This simple change provides various benefits for developers like compile
time errors, better auto-completition in editors and the ability of a
debugger to show the constant instead of just the raw value.
Thanks to Aaron Burghardt for the proposal.

1 files changed, 11 insertions, 15 deletions

diff --git a/include/libimobiledevice/file_relay.h b/include/libimobiledevice/file_relay.h
index 95aba6b..c0ab25c 100644
--- a/include/libimobiledevice/file_relay.h
+++ b/include/libimobiledevice/file_relay.h
@@ -32,21 +32,17 @@ extern "C" {
 
 #define FILE_RELAY_SERVICE_NAME "com.apple.mobile.file_relay"
 
-/** @name Error Codes */
-/*@{*/
-#define FILE_RELAY_E_SUCCESS                0
-#define FILE_RELAY_E_INVALID_ARG           -1
-#define FILE_RELAY_E_PLIST_ERROR           -2
-#define FILE_RELAY_E_MUX_ERROR             -3
-#define FILE_RELAY_E_INVALID_SOURCE        -4
-#define FILE_RELAY_E_STAGING_EMPTY         -5
-#define FILE_RELAY_E_PERMISSION_DENIED     -6
-
-#define FILE_RELAY_E_UNKNOWN_ERROR       -256
-/*@}*/
-
-/** Represents an error code. */
-typedef int16_t file_relay_error_t;
+/** Error Codes */
+typedef enum {
+        FILE_RELAY_E_SUCCESS           =  0,
+        FILE_RELAY_E_INVALID_ARG       = -1,
+        FILE_RELAY_E_PLIST_ERROR       = -2,
+        FILE_RELAY_E_MUX_ERROR         = -3,
+        FILE_RELAY_E_INVALID_SOURCE    = -4,
+        FILE_RELAY_E_STAGING_EMPTY     = -5,
+        FILE_RELAY_E_PERMISSION_DENIED = -6,
+        FILE_RELAY_E_UNKNOWN_ERROR     = -256
+} file_relay_error_t;
 
 typedef struct file_relay_client_private file_relay_client_private;
 typedef file_relay_client_private *file_relay_client_t; /**< The client handle. */