Convert int16_t macro error types into enum to improve debugging/type-checking

This simple change provides various benefits for developers like compile
time errors, better auto-completition in editors and the ability of a
debugger to show the constant instead of just the raw value.
Thanks to Aaron Burghardt for the proposal.

1 files changed, 9 insertions, 12 deletions

diff --git a/include/libimobiledevice/heartbeat.h b/include/libimobiledevice/heartbeat.h
index c943e51..7d8be39 100644
--- a/include/libimobiledevice/heartbeat.h
+++ b/include/libimobiledevice/heartbeat.h
@@ -32,18 +32,15 @@ extern "C" {
 
 #define HEARTBEAT_SERVICE_NAME "com.apple.mobile.heartbeat"
 
-/** @name Error Codes */
-/*@{*/
-#define HEARTBEAT_E_SUCCESS                0
-#define HEARTBEAT_E_INVALID_ARG           -1
-#define HEARTBEAT_E_PLIST_ERROR           -2
-#define HEARTBEAT_E_MUX_ERROR             -3
-#define HEARTBEAT_E_SSL_ERROR             -4
-#define HEARTBEAT_E_UNKNOWN_ERROR       -256
-/*@}*/
-
-/** Represents an error code. */
-typedef int16_t heartbeat_error_t;
+/** Error Codes */
+typedef enum {
+        HEARTBEAT_E_SUCCESS       =  0,
+        HEARTBEAT_E_INVALID_ARG   = -1,
+        HEARTBEAT_E_PLIST_ERROR   = -2,
+        HEARTBEAT_E_MUX_ERROR     = -3,
+        HEARTBEAT_E_SSL_ERROR     = -4,
+        HEARTBEAT_E_UNKNOWN_ERROR = -256
+} heartbeat_error_t;
 
 typedef struct heartbeat_client_private heartbeat_client_private;
 typedef heartbeat_client_private *heartbeat_client_t; /**< The client handle. */