Convert int16_t macro error types into enum to improve debugging/type-checking

This simple change provides various benefits for developers like compile
time errors, better auto-completition in editors and the ability of a
debugger to show the constant instead of just the raw value.
Thanks to Aaron Burghardt for the proposal.

1 files changed, 9 insertions, 13 deletions

diff --git a/include/libimobiledevice/house_arrest.h b/include/libimobiledevice/house_arrest.h
index 170cad2..9b7ff91 100644
--- a/include/libimobiledevice/house_arrest.h
+++ b/include/libimobiledevice/house_arrest.h
@@ -33,19 +33,15 @@ extern "C" {
 
 #define HOUSE_ARREST_SERVICE_NAME "com.apple.mobile.house_arrest"
 
-/** @name Error Codes */
-/*@{*/
-#define HOUSE_ARREST_E_SUCCESS                0
-#define HOUSE_ARREST_E_INVALID_ARG           -1
-#define HOUSE_ARREST_E_PLIST_ERROR           -2
-#define HOUSE_ARREST_E_CONN_FAILED           -3
-#define HOUSE_ARREST_E_INVALID_MODE          -4
-
-#define HOUSE_ARREST_E_UNKNOWN_ERROR       -256
-/*@}*/
-
-/** Represents an error code. */
-typedef int16_t house_arrest_error_t;
+/** Error Codes */
+typedef enum {
+        HOUSE_ARREST_E_SUCCESS       =  0,
+        HOUSE_ARREST_E_INVALID_ARG   = -1,
+        HOUSE_ARREST_E_PLIST_ERROR   = -2,
+        HOUSE_ARREST_E_CONN_FAILED   = -3,
+        HOUSE_ARREST_E_INVALID_MODE  = -4,
+        HOUSE_ARREST_E_UNKNOWN_ERROR = -256
+} house_arrest_error_t;
 
 typedef struct house_arrest_client_private house_arrest_client_private;
 typedef house_arrest_client_private *house_arrest_client_t; /**< The client handle. */