Convert int16_t macro error types into enum to improve debugging/type-checking

This simple change provides various benefits for developers like compile
time errors, better auto-completition in editors and the ability of a
debugger to show the constant instead of just the raw value.
Thanks to Aaron Burghardt for the proposal.

1 files changed, 9 insertions, 13 deletions

diff --git a/include/libimobiledevice/misagent.h b/include/libimobiledevice/misagent.h
index 7bb7333..28d55e8 100644
--- a/include/libimobiledevice/misagent.h
+++ b/include/libimobiledevice/misagent.h
@@ -32,19 +32,15 @@ extern "C" {
 
 #define MISAGENT_SERVICE_NAME "com.apple.misagent"
 
-/** @name Error Codes */
-/*@{*/
-#define MISAGENT_E_SUCCESS                0
-#define MISAGENT_E_INVALID_ARG           -1
-#define MISAGENT_E_PLIST_ERROR           -2
-#define MISAGENT_E_CONN_FAILED           -3
-#define MISAGENT_E_REQUEST_FAILED        -4
-
-#define MISAGENT_E_UNKNOWN_ERROR       -256
-/*@}*/
-
-/** Represents an error code. */
-typedef int16_t misagent_error_t;
+/** Error Codes */
+typedef enum {
+        MISAGENT_E_SUCCESS        =  0,
+        MISAGENT_E_INVALID_ARG    = -1,
+        MISAGENT_E_PLIST_ERROR    = -2,
+        MISAGENT_E_CONN_FAILED    = -3,
+        MISAGENT_E_REQUEST_FAILED = -4,
+        MISAGENT_E_UNKNOWN_ERROR  = -256
+} misagent_error_t;
 
 typedef struct misagent_client_private misagent_client_private;
 typedef misagent_client_private *misagent_client_t; /**< The client handle. */