Convert int16_t macro error types into enum to improve debugging/type-checking

This simple change provides various benefits for developers like compile
time errors, better auto-completition in editors and the ability of a
debugger to show the constant instead of just the raw value.
Thanks to Aaron Burghardt for the proposal.

1 files changed, 9 insertions, 13 deletions

diff --git a/include/libimobiledevice/mobile_image_mounter.h b/include/libimobiledevice/mobile_image_mounter.h
index 7fe2c2a..43a2d9c 100644
--- a/include/libimobiledevice/mobile_image_mounter.h
+++ b/include/libimobiledevice/mobile_image_mounter.h
@@ -32,19 +32,15 @@ extern "C" {
 
 #define MOBILE_IMAGE_MOUNTER_SERVICE_NAME "com.apple.mobile.mobile_image_mounter"
 
-/** @name Error Codes */
-/*@{*/
-#define MOBILE_IMAGE_MOUNTER_E_SUCCESS                0
-#define MOBILE_IMAGE_MOUNTER_E_INVALID_ARG           -1
-#define MOBILE_IMAGE_MOUNTER_E_PLIST_ERROR           -2
-#define MOBILE_IMAGE_MOUNTER_E_CONN_FAILED           -3
-#define MOBILE_IMAGE_MOUNTER_E_COMMAND_FAILED        -4
-
-#define MOBILE_IMAGE_MOUNTER_E_UNKNOWN_ERROR       -256
-/*@}*/
-
-/** Represents an error code. */
-typedef int16_t mobile_image_mounter_error_t;
+/** Error Codes */
+typedef enum {
+        MOBILE_IMAGE_MOUNTER_E_SUCCESS        =  0,
+        MOBILE_IMAGE_MOUNTER_E_INVALID_ARG    = -1,
+        MOBILE_IMAGE_MOUNTER_E_PLIST_ERROR    = -2,
+        MOBILE_IMAGE_MOUNTER_E_CONN_FAILED    = -3,
+        MOBILE_IMAGE_MOUNTER_E_COMMAND_FAILED = -4,
+        MOBILE_IMAGE_MOUNTER_E_UNKNOWN_ERROR  = -256
+} mobile_image_mounter_error_t;
 
 typedef struct mobile_image_mounter_client_private mobile_image_mounter_client_private;
 typedef mobile_image_mounter_client_private *mobile_image_mounter_client_t; /**< The client handle. */