Convert int16_t macro error types into enum to improve debugging/type-checking

This simple change provides various benefits for developers like compile
time errors, better auto-completition in editors and the ability of a
debugger to show the constant instead of just the raw value.
Thanks to Aaron Burghardt for the proposal.

1 files changed, 8 insertions, 12 deletions

diff --git a/include/libimobiledevice/notification_proxy.h b/include/libimobiledevice/notification_proxy.h
index a66057b..275be74 100644
--- a/include/libimobiledevice/notification_proxy.h
+++ b/include/libimobiledevice/notification_proxy.h
@@ -32,18 +32,14 @@ extern "C" {
 
 #define NP_SERVICE_NAME "com.apple.mobile.notification_proxy"
 
-/** @name Error Codes */
-/*@{*/
-#define NP_E_SUCCESS                0
-#define NP_E_INVALID_ARG           -1
-#define NP_E_PLIST_ERROR           -2
-#define NP_E_CONN_FAILED           -3
-
-#define NP_E_UNKNOWN_ERROR       -256
-/*@}*/
-
-/** Represents an error code. */
-typedef int16_t np_error_t;
+/** Error Codes */
+typedef enum {
+        NP_E_SUCCESS       =  0,
+        NP_E_INVALID_ARG   = -1,
+        NP_E_PLIST_ERROR   = -2,
+        NP_E_CONN_FAILED   = -3,
+        NP_E_UNKNOWN_ERROR = -256
+} np_error_t;
 
 /**
  * @name Notifications that can be send