Convert int16_t macro error types into enum to improve debugging/type-checking

This simple change provides various benefits for developers like compile
time errors, better auto-completition in editors and the ability of a
debugger to show the constant instead of just the raw value.
Thanks to Aaron Burghardt for the proposal.

1 files changed, 8 insertions, 12 deletions

diff --git a/include/libimobiledevice/sbservices.h b/include/libimobiledevice/sbservices.h
index f0bf2c4..f4f8dde 100644
--- a/include/libimobiledevice/sbservices.h
+++ b/include/libimobiledevice/sbservices.h
@@ -32,15 +32,14 @@ extern "C" {
 
 #define SBSERVICES_SERVICE_NAME "com.apple.springboardservices"
 
-/** @name Error Codes */
-/*@{*/
-#define SBSERVICES_E_SUCCESS                0
-#define SBSERVICES_E_INVALID_ARG           -1
-#define SBSERVICES_E_PLIST_ERROR           -2
-#define SBSERVICES_E_CONN_FAILED           -3
-
-#define SBSERVICES_E_UNKNOWN_ERROR       -256
-/*@}*/
+/** Error Codes */
+typedef enum {
+        SBSERVICES_E_SUCCESS       =  0,
+        SBSERVICES_E_INVALID_ARG   = -1,
+        SBSERVICES_E_PLIST_ERROR   = -2,
+        SBSERVICES_E_CONN_FAILED   = -3,
+        SBSERVICES_E_UNKNOWN_ERROR = -256
+} sbservices_error_t;
 
 /** @name Orientation of the user interface on the device */
 /*@{*/
@@ -53,9 +52,6 @@ typedef enum {
 } sbservices_interface_orientation_t;
 /*@}*/
 
-/** Represents an error code. */
-typedef int16_t sbservices_error_t;
-
 typedef struct sbservices_client_private sbservices_client_private;
 typedef sbservices_client_private *sbservices_client_t; /**< The client handle. */