Convert int16_t macro error types into enum to improve debugging/type-checking

This simple change provides various benefits for developers like compile
time errors, better auto-completition in editors and the ability of a
debugger to show the constant instead of just the raw value.
Thanks to Aaron Burghardt for the proposal.

1 files changed, 9 insertions, 13 deletions

diff --git a/include/libimobiledevice/screenshotr.h b/include/libimobiledevice/screenshotr.h
index 3601172..70cb2d2 100644
--- a/include/libimobiledevice/screenshotr.h
+++ b/include/libimobiledevice/screenshotr.h
@@ -33,19 +33,15 @@ extern "C" {
 
 #define SCREENSHOTR_SERVICE_NAME "com.apple.mobile.screenshotr"
 
-/** @name Error Codes */
-/*@{*/
-#define SCREENSHOTR_E_SUCCESS                0
-#define SCREENSHOTR_E_INVALID_ARG           -1
-#define SCREENSHOTR_E_PLIST_ERROR           -2
-#define SCREENSHOTR_E_MUX_ERROR             -3
-#define SCREENSHOTR_E_BAD_VERSION           -4
-
-#define SCREENSHOTR_E_UNKNOWN_ERROR       -256
-/*@}*/
-
-/** Represents an error code. */
-typedef int16_t screenshotr_error_t;
+/** Error Codes */
+typedef enum {
+        SCREENSHOTR_E_SUCCESS       =  0,
+        SCREENSHOTR_E_INVALID_ARG   = -1,
+        SCREENSHOTR_E_PLIST_ERROR   = -2,
+        SCREENSHOTR_E_MUX_ERROR     = -3,
+        SCREENSHOTR_E_BAD_VERSION   = -4,
+        SCREENSHOTR_E_UNKNOWN_ERROR = -256
+} screenshotr_error_t;
 
 typedef struct screenshotr_client_private screenshotr_client_private;
 typedef screenshotr_client_private *screenshotr_client_t; /**< The client handle. */