Convert int16_t macro error types into enum to improve debugging/type-checking

This simple change provides various benefits for developers like compile
time errors, better auto-completition in editors and the ability of a
debugger to show the constant instead of just the raw value.
Thanks to Aaron Burghardt for the proposal.

1 files changed, 8 insertions, 11 deletions

diff --git a/include/libimobiledevice/syslog_relay.h b/include/libimobiledevice/syslog_relay.h
index 952840e..1b9c4f1 100644
--- a/include/libimobiledevice/syslog_relay.h
+++ b/include/libimobiledevice/syslog_relay.h
@@ -32,17 +32,14 @@ extern "C" {
 
 #define SYSLOG_RELAY_SERVICE_NAME "com.apple.syslog_relay"
 
-/** @name Error Codes */
-/*@{*/
-#define SYSLOG_RELAY_E_SUCCESS                0
-#define SYSLOG_RELAY_E_INVALID_ARG           -1
-#define SYSLOG_RELAY_E_MUX_ERROR             -2
-#define SYSLOG_RELAY_E_SSL_ERROR             -3
-#define SYSLOG_RELAY_E_UNKNOWN_ERROR       -256
-/*@}*/
-
-/** Represents an error code. */
-typedef int16_t syslog_relay_error_t;
+/** Error Codes */
+typedef enum {
+        SYSLOG_RELAY_E_SUCCESS       =  0,
+        SYSLOG_RELAY_E_INVALID_ARG   = -1,
+        SYSLOG_RELAY_E_MUX_ERROR     = -2,
+        SYSLOG_RELAY_E_SSL_ERROR     = -3,
+        SYSLOG_RELAY_E_UNKNOWN_ERROR = -256
+} syslog_relay_error_t;
 
 typedef struct syslog_relay_client_private syslog_relay_client_private;
 typedef syslog_relay_client_private *syslog_relay_client_t; /**< The client handle. */