Fixed memory leak by creating empty plist dict for iTunes settings only when it can’t be retrieved from the lockdown connection. That mimics the leaking implementation, but maybe it should be an error.

1 files changed, 2 insertions, 2 deletions

diff --git a/tools/idevicebackup2.c b/tools/idevicebackup2.c
index 697e276..8921403 100644
--- a/tools/idevicebackup2.c
+++ b/tools/idevicebackup2.c
@@ -354,9 +354,9 @@ static plist_t mobilebackup_factory_info_plist_new(const char* udid, lockdownd_c
 	}
 	plist_dict_insert_item(ret, "iTunes Files", files);
 
-	plist_t itunes_settings = plist_new_dict();
+	plist_t itunes_settings = NULL;
 	lockdownd_get_value(lockdown, "com.apple.iTunes", NULL, &itunes_settings);
-	plist_dict_insert_item(ret, "iTunes Settings", itunes_settings);
+	plist_dict_insert_item(ret, "iTunes Settings", itunes_settings ? itunes_settings : plist_new_dict());
 
 	plist_dict_insert_item(ret, "iTunes Version", plist_new_string("10.0.1"));