1 files changed, 181 insertions, 78 deletions

diff --git a/tools/idevicescreenshot.c b/tools/idevicescreenshot.c
index 8567f77..0e694c7 100644
--- a/tools/idevicescreenshot.c
+++ b/tools/idevicescreenshot.c
@@ -1,113 +1,227 @@
-/**
- * idevicescreenshot -- Gets a screenshot from a connected iPhone/iPod Touch
+/*
+ * idevicescreenshot.c
+ * Gets a screenshot from a device
  *
  * Copyright (C) 2010 Nikias Bassen <nikias@gmx.li>
  *
- * Licensed under the GNU General Public License Version 2
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
+ * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more profile.
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
  *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 
- * USA
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
  */
 
+#ifdef HAVE_CONFIG_H
+#include <config.h>
+#endif
+
+#define TOOL_NAME "idevicescreenshot"
+
 #include <stdio.h>
 #include <string.h>
 #include <stdlib.h>
+#include <getopt.h>
 #include <errno.h>
 #include <time.h>
+#include <unistd.h>
+#ifndef WIN32
+#include <signal.h>
+#endif
 
 #include <libimobiledevice/libimobiledevice.h>
 #include <libimobiledevice/lockdown.h>
 #include <libimobiledevice/screenshotr.h>
 
-void print_usage(int argc, char **argv);
+static void get_image_filename(char *imgdata, char **filename)
+{
+        // If the provided filename already has an extension, use it as is.
+        if (*filename) {
+                char *last_dot = strrchr(*filename, '.');
+                if (last_dot && !strchr(last_dot, '/')) {
+                        return;
+                }
+        }
+
+        // Find the appropriate file extension for the filename.
+        const char *fileext = NULL;
+        if (memcmp(imgdata, "\x89PNG", 4) == 0) {
+                fileext = ".png";
+        } else if (memcmp(imgdata, "MM\x00*", 4) == 0) {
+                fileext = ".tiff";
+        } else {
+                printf("WARNING: screenshot data has unexpected image format.\n");
+                fileext = ".dat";
+        }
+
+        // If a filename without an extension is provided, append the extension.
+        // Otherwise, generate a filename based on the current time.
+        char *basename = NULL;
+        if (*filename) {
+                basename = (char*)malloc(strlen(*filename) + 1);
+                strcpy(basename, *filename);
+                free(*filename);
+                *filename = NULL;
+        } else {
+                time_t now = time(NULL);
+                basename = (char*)malloc(32);
+                strftime(basename, 31, "screenshot-%Y-%m-%d-%H-%M-%S", gmtime(&now));
+        }
+
+        // Ensure the filename is unique on disk.
+        char *unique_filename = (char*)malloc(strlen(basename) + strlen(fileext) + 7);
+        sprintf(unique_filename, "%s%s", basename, fileext);
+        int i;
+        for (i = 2; i < (1 << 16); i++) {
+                if (access(unique_filename, F_OK) == -1) {
+                        *filename = unique_filename;
+                        break;
+                }
+                sprintf(unique_filename, "%s-%d%s", basename, i, fileext);
+        }
+        if (!*filename) {
+                free(unique_filename);
+        }
+        free(basename);
+}
+
+static void print_usage(int argc, char **argv, int is_error)
+{
+        char *name = strrchr(argv[0], '/');
+        fprintf(is_error ? stderr : stdout, "Usage: %s [OPTIONS] [FILE]\n", (name ? name + 1: argv[0]));
+        fprintf(is_error ? stderr : stdout,
+                "\n"
+                "Gets a screenshot from a connected device.\n"
+                "\n"
+                "The image is in PNG format for iOS 9+ and otherwise in TIFF format.\n"
+                "The screenshot is saved as an image with the given FILE name.\n"
+                "If FILE has no extension, FILE will be a prefix of the saved filename.\n"
+                "If FILE is not specified, \"screenshot-DATE\", will be used as a prefix\n"
+                "of the filename, e.g.:\n"
+                "   ./screenshot-2013-12-31-23-59-59.tiff\n"
+                "\n"
+                "NOTE: A mounted developer disk image is required on the device, otherwise\n"
+                "the screenshotr service is not available.\n"
+                "\n"
+                "  -u, --udid UDID       target specific device by UDID\n"
+                "  -n, --network         connect to network device\n"
+                "  -d, --debug           enable communication debugging\n"
+                "  -h, --help            prints usage information\n"
+                "  -v, --version         prints version information\n"
+                "\n"
+                "Homepage:    <" PACKAGE_URL ">\n"
+                "Bug Reports: <" PACKAGE_BUGREPORT ">\n"
+        );
+}
 
 int main(int argc, char **argv)
 {
         idevice_t device = NULL;
         lockdownd_client_t lckd = NULL;
+        lockdownd_error_t ldret = LOCKDOWN_E_UNKNOWN_ERROR;
         screenshotr_client_t shotr = NULL;
-        uint16_t port = 0;
+        lockdownd_service_descriptor_t service = NULL;
         int result = -1;
-        int i;
-        char *uuid = NULL;
+        const char *udid = NULL;
+        int use_network = 0;
+        char *filename = NULL;
+        int c = 0;
+        const struct option longopts[] = {
+                { "debug", no_argument, NULL, 'd' },
+                { "help", no_argument, NULL, 'h' },
+                { "udid", required_argument, NULL, 'u' },
+                { "network", no_argument, NULL, 'n' },
+                { "version", no_argument, NULL, 'v' },
+                { NULL, 0, NULL, 0}
+        };
 
+#ifndef WIN32
+        signal(SIGPIPE, SIG_IGN);
+#endif
         /* parse cmdline args */
-        for (i = 1; i < argc; i++) {
-                if (!strcmp(argv[i], "-d") || !strcmp(argv[i], "--debug")) {
+
+        /* parse cmdline arguments */
+        while ((c = getopt_long(argc, argv, "dhu:nv", longopts, NULL)) != -1) {
+                switch (c) {
+                case 'd':
                         idevice_set_debug_level(1);
-                        continue;
-                }
-                else if (!strcmp(argv[i], "-u") || !strcmp(argv[i], "--uuid")) {
-                        i++;
-                        if (!argv[i] || (strlen(argv[i]) != 40)) {
-                                print_usage(argc, argv);
-                                return 0;
+                        break;
+                case 'u':
+                        if (!*optarg) {
+                                fprintf(stderr, "ERROR: UDID argument must not be empty!\n");
+                                print_usage(argc, argv, 1);
+                                return 2;
                         }
-                        uuid = strdup(argv[i]);
-                        continue;
-                }
-                else if (!strcmp(argv[i], "-h") || !strcmp(argv[i], "--help")) {
-                        print_usage(argc, argv);
+                        udid = optarg;
+                        break;
+                case 'n':
+                        use_network = 1;
+                        break;
+                case 'h':
+                        print_usage(argc, argv, 0);
                         return 0;
-                }
-                else {
-                        print_usage(argc, argv);
+                case 'v':
+                        printf("%s %s\n", TOOL_NAME, PACKAGE_VERSION);
                         return 0;
+                default:
+                        print_usage(argc, argv, 1);
+                        return 2;
                 }
         }
+        argc -= optind;
+        argv += optind;
 
-        if (IDEVICE_E_SUCCESS != idevice_new(&device, uuid)) {
-                printf("No device found, is it plugged in?\n");
-                if (uuid) {
-                        free(uuid);
+        if (argv[0]) {
+                filename = strdup(argv[0]);
+        }
+
+        if (IDEVICE_E_SUCCESS != idevice_new_with_options(&device, udid, (use_network) ? IDEVICE_LOOKUP_NETWORK : IDEVICE_LOOKUP_USBMUX)) {
+                if (udid) {
+                        printf("No device found with udid %s.\n", udid);
+                } else {
+                        printf("No device found.\n");
                 }
                 return -1;
         }
-        if (uuid) {
-                free(uuid);
-        }
 
-        if (LOCKDOWN_E_SUCCESS != lockdownd_client_new_with_handshake(device, &lckd, NULL)) {
+        if (LOCKDOWN_E_SUCCESS != (ldret = lockdownd_client_new_with_handshake(device, &lckd, TOOL_NAME))) {
                 idevice_free(device);
-                printf("Exiting.\n");
+                printf("ERROR: Could not connect to lockdownd, error code %d\n", ldret);
                 return -1;
         }
 
-        lockdownd_start_service(lckd, "com.apple.mobile.screenshotr", &port);
+        lockdownd_error_t lerr = lockdownd_start_service(lckd, SCREENSHOTR_SERVICE_NAME, &service);
         lockdownd_client_free(lckd);
-        if (port > 0) {
-                if (screenshotr_client_new(device, port, &shotr) != SCREENSHOTR_E_SUCCESS) {
+        if (lerr == LOCKDOWN_E_SUCCESS) {
+                if (screenshotr_client_new(device, service, &shotr) != SCREENSHOTR_E_SUCCESS) {
                         printf("Could not connect to screenshotr!\n");
                 } else {
                         char *imgdata = NULL;
-                        char filename[36];
                         uint64_t imgsize = 0;
-                        time_t now = time(NULL);
-                        strftime(filename, 36, "screenshot-%Y-%m-%d-%H-%M-%S.tiff", gmtime(&now));
                         if (screenshotr_take_screenshot(shotr, &imgdata, &imgsize) == SCREENSHOTR_E_SUCCESS) {
-                                FILE *f = fopen(filename, "w");
-                                if (f) {
-                                        if (fwrite(imgdata, 1, (size_t)imgsize, f) == (size_t)imgsize) {
-                                                printf("Screenshot saved to %s\n", filename);
-                                                result = 0;
+                                get_image_filename(imgdata, &filename);
+                                if (!filename) {
+                                        printf("FATAL: Could not find a unique filename!\n");
+                                } else {
+                                        FILE *f = fopen(filename, "wb");
+                                        if (f) {
+                                                if (fwrite(imgdata, 1, (size_t)imgsize, f) == (size_t)imgsize) {
+                                                        printf("Screenshot saved to %s\n", filename);
+                                                        result = 0;
+                                                } else {
+                                                        printf("Could not save screenshot to file %s!\n", filename);
+                                                }
+                                                fclose(f);
                                         } else {
-                                                printf("Could not save screenshot to file %s!\n", filename);
+                                                printf("Could not open %s for writing: %s\n", filename, strerror(errno));
                                         }
-                                        fclose(f);
-                                } else {
-                                        printf("Could not open %s for writing: %s\n", filename, strerror(errno));
                                 }
                         } else {
                                 printf("Could not get screenshot!\n");
@@ -115,25 +229,14 @@ int main(int argc, char **argv)
                         screenshotr_client_free(shotr);
                 }
         } else {
-                printf("Could not start screenshotr service! Remember that you have to mount the Developer disk image on your device if you want to use the screenshotr service.\n");
+                printf("Could not start screenshotr service: %s\nRemember that you have to mount the Developer disk image on your device if you want to use the screenshotr service.\n", lockdownd_strerror(lerr));
         }
+
+        if (service)
+                lockdownd_service_descriptor_free(service);
+
         idevice_free(device);
-        
-        return result;
-}
+        free(filename);
 
-void print_usage(int argc, char **argv)
-{
-        char *name = NULL;
-
-        name = strrchr(argv[0], '/');
-        printf("Usage: %s [OPTIONS]\n", (name ? name + 1: argv[0]));
-        printf("Gets a screenshot from the connected iPhone/iPod Touch.\n");
-        printf("The screenshot is saved as a TIFF image in the current directory.\n");
-        printf("NOTE: A mounted developer disk image is required on the device, otherwise\n");
-        printf("the screenshotr service is not available.\n\n");
-        printf("  -d, --debug\t\tenable communication debugging\n");
-        printf("  -u, --uuid UUID\ttarget specific device by its 40-digit device UUID\n");
-        printf("  -h, --help\t\tprints usage information\n");
-        printf("\n");
+        return result;
 }