| Age | Commit message (Collapse) | Author | Files | Lines | |
|---|---|---|---|---|---|
| 11 hours | afc: validate entire_length/this_length in afc_receive_dataHEADmaster | 1 | -1/+5 | ||
| The AFC packet header fields entire_length and this_length were only checked to ensure this_length >= sizeof(AFCPacket). Neither field was validated against the other, allowing a malicious or compromised device to trigger: - A heap buffer overflow (CWE-787): if this_length > entire_length, buf is malloc'd with the smaller entire_len but service_receive() writes this_len attacker-controlled bytes into it. - An integer underflow leading to a crash (CWE-191): if entire_length < sizeof(AFCPacket), entire_len underflows to a huge value, malloc() fails, and the returned NULL buf is later dereferenced. Add explicit checks that entire_length is at least sizeof(AFCPacket) and fits in 32 bits, and that this_length never exceeds entire_length, rejecting malformed packets with AFC_E_OP_HEADER_INVALID. Also handle malloc() failure by returning AFC_E_NO_MEM instead of proceeding with a NULL buffer. Reported September 1st, 2026 Reported-by: Karnakar Reddy <karnakarthoorpu@gmail.com> | |||||
| 2025-11-25 | afc: Improve error handling | 1 | -15/+63 | ||
| 2025-06-28 | afc: Add afc_get_file_info_plist and afc_get_device_info_plist functions | 1 | -2/+116 | ||
| These functions are like afc_get_file_info/afc_get_device_info but the data is returned as a plist_t dictionary instead of a string list. | |||||
| 2024-11-29 | Fix compilation on MSVC | 1 | -2/+5 | ||
| 2024-11-29 | Fix attempts to detect Windows using _WIN32 | 1 | -1/+1 | ||
| 2024-02-01 | Add afc_strerror function to interface | 1 | -0/+67 | ||
| 2024-01-31 | Move LIBIMOBILEDEVICE_API to public headers | 1 | -25/+25 | ||
| 2022-04-30 | [clang-tidy] Do not use else after return | 1 | -15/+19 | ||
| Signed-off-by: Rosen Penev <rosenp@gmail.com> | |||||
| 2022-04-22 | [clang-tidy] Fix bugprone string compare | 1 | -1/+1 | ||
| Found with bugprone-suspicious-string-compare Signed-off-by: Rosen Penev <rosenp@gmail.com> | |||||
| 2022-04-22 | [clang-tidy] use const pointer parameter | 1 | -1/+1 | ||
| Found with readability-non-const-parameter Signed-off-by: Rosen Penev <rosenp@gmail.com> | |||||
| 2022-03-25 | afc: Some minor code polishing | 1 | -24/+25 | ||
| 2021-07-27 | afc: Suppress compiler warning when compiling without --enable-debug | 1 | -2/+1 | ||
| 2020-05-19 | afc: Reduce packet segmentation and unnecessary malloc/free | 1 | -97/+187 | ||
| 2020-04-13 | afc: Remove unused client struct members from afc.c too | 1 | -2/+0 | ||
| 2015-01-28 | Remove trailing whitespace errors from all files | 1 | -12/+12 | ||
| 2014-10-03 | Avoid exporting non-public symbols | 1 | -24/+24 | ||
| 2014-10-02 | afc: Implement afc_remove_path_and_contents() for recursive deletion | 1 | -0/+24 | ||
| Only available on iOS 6 and later. | |||||
| 2014-10-02 | afc: Unify argument names for some functions to match overall API | 1 | -12/+12 | ||
| 2014-10-02 | afc: Update all currently known AFC operations in enum | 1 | -3/+4 | ||
| 2014-10-02 | afc: Change wrong function return types to match header | 1 | -7/+3 | ||
| 2014-08-25 | afc.c: fixed leaks in various functions when an invalid argument error is ↵ | 1 | -12/+12 | ||
| returned. | |||||
| 2014-08-22 | afc_file_tell: fixed leak of unnecessary buffer and removed condition check ↵ | 1 | -3/+2 | ||
| before free. | |||||
| 2014-08-22 | afc_file_open: fixed memory leak when the object is not found or arguments ↵ | 1 | -3/+6 | ||
| are invalid. | |||||
| 2014-03-27 | Moved Doxygen comments from source files to public headers. | 1 | -212/+0 | ||
| Conflicts: include/libimobiledevice/afc.h | |||||
| 2014-03-24 | afc: Rename variable 'send' to 'buffer' to silence compiler warning about ↵ | 1 | -21/+21 | ||
| shadowing a global declaration | |||||
| 2014-03-22 | Update copyright in various files | 1 | -0/+1 | ||
| 2014-03-21 | afc: Remove segmentation code from afc_file_read() | 1 | -51/+34 | ||
| 2014-03-13 | afc: use static buffers where possible | 1 | -29/+30 | ||
| 2014-03-13 | afc: refactor afc_dispatch_packet and improve afc_file_write performance | 1 | -252/+109 | ||
| 2013-11-04 | Convert stray spaces to corresponding tabs | 1 | -8/+8 | ||
| 2013-10-09 | Remove duplicate newline from debug messages as one is added automatically | 1 | -1/+1 | ||
| 2013-09-16 | afc: fix some return types (afc_error_t vs. idevice_error_t) | 1 | -4/+4 | ||
| 2013-08-05 | Implement *_start_service() helper to simplify creation of service clients | 1 | -0/+20 | ||
| 2013-04-25 | common: Move debug and userpref code into libinternalcommon | 1 | -1/+1 | ||
| 2013-04-25 | afc: Add convenience helper to free AFC dictionaries in afc_dictionary_free() | 1 | -0/+14 | ||
| 2013-03-20 | use new internal common code for thread, mutex, and socket operations | 1 | -20/+4 | ||
| 2013-03-14 | global: make sure to check service before checking service->port to prevent ↵ | 1 | -1/+1 | ||
| crashes | |||||
| 2013-02-27 | afc: List afc_client_new_with_service_client() in private header | 1 | -4/+4 | ||
| 2013-02-27 | implement base service that all other services inherit from | 1 | -41/+30 | ||
| 2013-02-26 | Refactor port number use into service descriptor to enable SSL for services | 1 | -4/+8 | ||
| This is a major change which breaks API but is required in order to support SSL communication for services as used by network connections. | |||||
| 2012-11-29 | afc: fix documentation to say 'device' instead of 'phone' | 1 | -11/+11 | ||
| 2012-03-19 | New file for be*/le* macros plus check for endian.h presence | 1 | -0/+1 | ||
| 2012-03-19 | WIN32: use windows threads and mutexes instead of pthread_* | 1 | -0/+18 | ||
| 2012-03-18 | Include config.h if HAVE_CONFIG_H | 1 | -0/+3 | ||
| 2012-03-18 | Completely remove glib dependency. | 1 | -13/+15 | ||
| 2012-03-18 | Remove gthread dependency and use pthreads instead | 1 | -14/+4 | ||
| 2010-11-05 | afc: new function afc_client_new_from_connection | 1 | -20/+60 | ||
| This function allows creating an afc client upon an already established connection. This is for example required for the house_arrest service. | |||||
| 2010-09-01 | afc: fix reading of afc status codes on big endian machines | 1 | -1/+1 | ||
| 2010-08-27 | afc: fix packet communication on big endian machines | 1 | -0/+2 | ||
| 2010-03-24 | Remove unused and fix some includes | 1 | -0/+1 | ||
