summaryrefslogtreecommitdiffstats
path: root/src
AgeCommit message (Collapse)AuthorFilesLines
2015-01-12lockdown: Refactor internal error checking and add more native errors to enumGravatar Martin Szulecki1-82/+123
2015-01-12Fix overlong blocking in np_client_free()Gravatar Christophe Fergeau1-3/+7
When using ideviceinstaller, np_client_free() would block for several minutes when ideviceinstaller cleans up after installing the application. This happens because the function is blocking on thread_join(), waiting for the notification watcher thread to finish. It only ends when np_get_notification() returns a negative value after getting a timeout, which takes several minutes. However, the thread loop will also exit early if client->parent gets NULL (the loop is iterated every 500ms), so this commit ensures client->parent gets set to NULL early in np_client_free() so that thread_join() does not block for a long time. Signed-off-by: Martin Szulecki <m.szulecki@libimobiledevice.org>
2014-12-10lockdown: Add new LOCKDOWN_E_SERVICE_LIMIT error to detect service limit statesGravatar Martin Szulecki1-0/+2
2014-12-09debugserver: Return enum error type instead of int for type consistencyGravatar Martin Szulecki1-1/+1
2014-12-09debugserver: Remove const argv requirement for creating commandsGravatar Martin Szulecki1-2/+5
2014-11-11notification_proxy: Send Shutdown command in np_client_free() instead of ↵Gravatar Nikias Bassen1-33/+34
np_post_notification()
2014-10-27debug: Fix linking failure on OS X by keeping debug level symbol internalGravatar Martin Szulecki2-3/+1
This change keeps the debug level symbol within the internal convenience library and makes it accessible using an internal helper. This fixes linking, prevents new exported symbols and finally allows proper control of enabling debug messages.
2014-10-26debug: Fix symbol locality for linker so debug messages are printed againGravatar Martin Szulecki2-1/+8
2014-10-26Remove obsolete prefix from debug messages in internal locking helpersGravatar Martin Szulecki3-6/+6
2014-10-26lockdown: Fix error in re-pairing when previous record became invalidGravatar BALATON Zoltan1-9/+5
When connecting with an existing pair record failed we attempted to pair again which generated a new host id but then connect after successful pairing tried to use host id from the old record and failed. Make sure we forget the old host id when re-pairing. This also fixes a possible memory leak.
2014-10-09debugserver: Fix wrong service_error_t return type in debugserver_client_send()Gravatar Martin Szulecki1-1/+1
2014-10-07idevice: Fix compilation with OpenSSL before 1.0.0-beta1Gravatar Martin Szulecki1-0/+12
2014-10-05Convert int16_t macro error types into enum to improve debugging/type-checkingGravatar Martin Szulecki5-11/+15
This simple change provides various benefits for developers like compile time errors, better auto-completition in editors and the ability of a debugger to show the constant instead of just the raw value. Thanks to Aaron Burghardt for the proposal.
2014-10-03mobilesync: Fix crash in mobilesync_recive_changes() due to typoGravatar Martin Szulecki1-1/+1
2014-10-03debugserver: Fix compiler warning about missing bracesGravatar Martin Szulecki1-2/+4
2014-10-03Avoid exporting non-public symbolsGravatar Martin Szulecki23-242/+249
2014-10-02lockdown: Added lockdownd_start_service_with_escrow_bagGravatar Koby Boyango1-5/+79
Signed-off-by: Martin Szulecki <m.szulecki@libimobiledevice.org>
2014-10-02afc: Implement afc_remove_path_and_contents() for recursive deletionGravatar Martin Szulecki1-0/+24
Only available on iOS 6 and later.
2014-10-02afc: Unify argument names for some functions to match overall APIGravatar Martin Szulecki1-12/+12
2014-10-02afc: Update all currently known AFC operations in enumGravatar Martin Szulecki2-32/+48
2014-10-02afc: Change wrong function return types to match headerGravatar Martin Szulecki1-7/+3
2014-10-01idevice: Fix several memory leaks on deinitialization of OpenSSLGravatar Martin Szulecki1-8/+16
2014-09-19Add protocol implementation for debugserver serviceGravatar Martin Szulecki3-0/+662
2014-09-19file_relay: Handle new PermissionDenied error (iOS 8 GM+)Gravatar Martin Szulecki1-0/+3
2014-08-25afc.c: fixed leaks in various functions when an invalid argument error is ↵Gravatar Aaron Burghardt1-12/+12
returned.
2014-08-22afc_file_tell: fixed leak of unnecessary buffer and removed condition check ↵Gravatar Aaron Burghardt1-3/+2
before free.
2014-08-22afc_file_open: fixed memory leak when the object is not found or arguments ↵Gravatar Aaron Burghardt1-3/+6
are invalid.
2014-08-06lockdown: Only set SystemBUID in pair_record_generate() if it actually ↵Gravatar Nikias Bassen1-1/+2
contains a value This will prevent a crash in libplist when plist_new_string() will be called with a NULL pointer.
2014-08-06lockdown: Silence compiler warning about ignored return value from asprintf()Gravatar Nikias Bassen1-8/+10
2014-06-13mobile_image_mounter: Change upload method to accept optional image signatureGravatar Martin Szulecki1-4/+7
2014-06-05idevice: win32: Use correct signature for DllMain()Gravatar Nikias Bassen1-2/+1
2014-05-05lockdown: cleanup: remove pointless gotoGravatar Andreas Henriksson1-4/+0
Minor cleanup. Drop useless code. We're already at "leave", so there's no need to (conditionally!) goto it.
2014-05-05lockdown: avoid crashing when getting system buid failsGravatar Andreas Henriksson1-2/+3
When userpref_read_system_buid fails to retrieve the buid, systembuid will be set to NULL. It was then unconditionally passed to plist_new_string - which will crash with a NULL argument. See https://bugs.debian.org/730756 for people reporting this happening in the real world. See https://github.com/libimobiledevice/libimobiledevice/commit/1331f6baa1799e41003aa812c0d1bf36193535ea ("lockdown: Make sure to set SystemBUID in generated pair records") for the commit where this problem was introduced.
2014-04-29Make property_list_service publicGravatar Nikias Bassen2-132/+1
2014-03-27Moved Doxygen comments from source files to public headers.Gravatar Aaron Burghardt20-2478/+2
Conflicts: include/libimobiledevice/afc.h
2014-03-27lockdown: Return error if getting a lockdown value failed to fix segfaultGravatar Martin Szulecki1-0/+2
https://github.com/libimobiledevice/libimobiledevice/issues/67 The lockdownd_get_value() function is not properly handling an error situation. The code logic always returned success as long as the lockdown response was properly received. Thanks to Aaron Burghardt for spotting this.
2014-03-24win32: Silence compiler warning about missing previous declaration of DllMainGravatar Nikias Bassen1-0/+5
2014-03-24afc: Rename variable 'send' to 'buffer' to silence compiler warning about ↵Gravatar Nikias Bassen1-21/+21
shadowing a global declaration
2014-03-24lockdown: Prevent libplist assertion by checking result of ↵Gravatar Nikias Bassen1-4/+10
userpref_read_pair_record()
2014-03-22Fix make distcheck by using $(top_builddir) where needed1.1.6Gravatar Martin Szulecki1-1/+1
2014-03-22Update copyright in various filesGravatar Martin Szulecki4-1/+6
2014-03-21afc: Remove segmentation code from afc_file_read()Gravatar Nikias Bassen1-51/+34
2014-03-21lockdown: Fix starting unsecure services as needed during trust dialog pairingGravatar Martin Szulecki1-14/+0
2014-03-21lockdown: Fix fetching WiFi address for pair record after trust dialog pairingGravatar Martin Szulecki1-12/+20
2014-03-21implement global thread safe library initializationGravatar Nikias Bassen1-9/+80
2014-03-21lockdown: Correct a few comments within pair generation codeGravatar Martin Szulecki1-1/+2
2014-03-21idevice: Use more common "ERROR:" syntax for error messagesGravatar Martin Szulecki1-2/+2
2014-03-21lockdown: Move HostID generation closer to code setting it in pair recordGravatar Martin Szulecki1-2/+1
2014-03-21lockdown: Read HostID again after pairing to fix first pair workflowGravatar Martin Szulecki1-0/+7
2014-03-21idevice: Fix misleading warning in GnuTLS SSL handshakeGravatar Martin Szulecki1-2/+2