From 8e96f2af5960f4f5e4b52e4d7fe4e3c0ff2fe655 Mon Sep 17 00:00:00 2001 From: Aaron Burghardt Date: Tue, 19 Aug 2014 12:45:16 -0400 Subject: afc_file_tell: fixed leak of unnecessary buffer and removed condition check before free. --- src/afc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/afc.c b/src/afc.c index b305859..7304d97 100644 --- a/src/afc.c +++ b/src/afc.c @@ -846,7 +846,7 @@ afc_error_t afc_file_seek(afc_client_t client, uint64_t handle, int64_t offset, afc_error_t afc_file_tell(afc_client_t client, uint64_t handle, uint64_t *position) { - char *buffer = (char *) malloc(sizeof(char) * 8); + char *buffer = NULL; uint32_t bytes = 0; afc_error_t ret = AFC_E_UNKNOWN_ERROR; @@ -870,8 +870,7 @@ afc_error_t afc_file_tell(afc_client_t client, uint64_t handle, uint64_t *positi memcpy(position, buffer, sizeof(uint64_t)); *position = le64toh(*position); } - if (buffer) - free(buffer); + free(buffer); afc_unlock(client); -- cgit v1.1-32-gdbae