From a1fc3913b30a5b078ce73228e3a5e96416fb8059 Mon Sep 17 00:00:00 2001
From: Nikias Bassen
Date: Tue, 24 Sep 2013 02:15:43 +0200
Subject: restore: improve restored_query_type result checking

---
 src/restore.c | 25 ++++++++++++++-----------
 1 file changed, 14 insertions(+), 11 deletions(-)

(limited to 'src/restore.c')

diff --git a/src/restore.c b/src/restore.c
index 85009e4..a7f07f2 100644
--- a/src/restore.c
+++ b/src/restore.c
@@ -232,20 +232,20 @@ restored_error_t restored_query_type(restored_client_t client, char **type, uint
 		return ret;
 
 	ret = RESTORE_E_UNKNOWN_ERROR;
-	if (restored_check_result(dict) == RESULT_SUCCESS) {
+	plist_t type_node = plist_dict_get_item(dict, "Type");
+	if (type_node && (plist_get_node_type(type_node) == PLIST_STRING)) {
+		char* typestr = NULL;
+
 		/* save our device information info */
 		client->info = dict;
-		
+
+		plist_get_string_val(type_node, &typestr);
+		debug_info("success with type %s", typestr);
 		/* return the type if requested */
 		if (type) {
-			plist_t type_node = plist_dict_get_item(dict, "Type");
-			if (type_node && PLIST_STRING == plist_get_node_type(type_node)) {
-				plist_get_string_val(type_node, type);
-				debug_info("success with type %s", *type);
-				ret = RESTORE_E_SUCCESS;
-			} else {
-				return RESTORE_E_UNKNOWN_ERROR;
-			}
+			*type = typestr;
+		} else {
+			free(typestr);
 		}
 
 		/* fetch the restore protocol version */
@@ -254,12 +254,15 @@ restored_error_t restored_query_type(restored_client_t client, char **type, uint
 			if (version_node && PLIST_UINT == plist_get_node_type(version_node)) {
 				plist_get_uint_val(version_node, version);
 				debug_info("restored protocol version %llu", *version);
-				ret = RESTORE_E_SUCCESS;
 			} else {
 				return RESTORE_E_UNKNOWN_ERROR;
 			}
 		}
 		ret = RESTORE_E_SUCCESS;
+	} else {
+		debug_info("hmm. QueryType response does not contain a type?!\n");
+		debug_plist(dict);
+		plist_free(dict);
 	}
 
 	return ret;
-- 
cgit v1.1-32-gdbae