From ef7cf8eb545d9ed3fb1f351376dec71608d0127b Mon Sep 17 00:00:00 2001 From: Nikias Bassen Date: Wed, 14 Sep 2022 12:22:07 +0200 Subject: restore: Remove incorrect invocation of free() in restored_get_value The free would cause a use-after-free when the plist is later freed, which eventually ends up in a crash. Thanks @TrungNguyen1909 for catching this. --- src/restore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/restore.c b/src/restore.c index 591fd16..41bfb9d 100644 --- a/src/restore.c +++ b/src/restore.c @@ -287,7 +287,7 @@ LIBIMOBILEDEVICE_API restored_error_t restored_get_value(restored_client_t clien } *value = plist_copy(item); - free(item); + return RESTORE_E_SUCCESS; } -- cgit v1.1-32-gdbae