From 8521693b1199e1e5274efed00c908afc8a128516 Mon Sep 17 00:00:00 2001
From: Aaron Burghardt
Date: Sun, 30 Jun 2013 20:52:51 -0400
Subject: Fixed multiple occurrences of memory leaks when empty plist dicts are
 passed to mobilebackup2_send_status_response().

---
 tools/idevicebackup2.c | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

(limited to 'tools')

diff --git a/tools/idevicebackup2.c b/tools/idevicebackup2.c
index 45ff489..41591eb 100644
--- a/tools/idevicebackup2.c
+++ b/tools/idevicebackup2.c
@@ -1006,7 +1006,10 @@ static int mb2_handle_receive_files(mobilebackup2_client_t mobilebackup2, plist_
 		free(dname);
 
 	// TODO error handling?!
-	mobilebackup2_send_status_response(mobilebackup2, 0, NULL, plist_new_dict());
+	plist_t empty_plist = plist_new_dict();
+	mobilebackup2_send_status_response(mobilebackup2, 0, NULL, empty_plist);
+	plist_free(empty_plist);
+
 	return file_count;
 }
 
@@ -1997,7 +2000,9 @@ checkpoint:
 						errdesc = "Could not create dict iterator";
 						printf("Could not create dict iterator\n");
 					}
-					err = mobilebackup2_send_status_response(mobilebackup2, errcode, errdesc, plist_new_dict());
+					plist_t empty_dict = plist_new_dict();
+					err = mobilebackup2_send_status_response(mobilebackup2, errcode, errdesc, empty_dict);
+					plist_free(empty_dict);
 					if (err != MOBILEBACKUP2_E_SUCCESS) {
 						printf("Could not send status response, error %d\n", err);
 					}
@@ -2049,7 +2054,9 @@ checkpoint:
 							}
 						}
 					}
-					err = mobilebackup2_send_status_response(mobilebackup2, errcode, errdesc, plist_new_dict());
+					plist_t empty_dict = plist_new_dict();
+					err = mobilebackup2_send_status_response(mobilebackup2, errcode, errdesc, empty_dict);
+					plist_free(empty_dict);
 					if (err != MOBILEBACKUP2_E_SUCCESS) {
 						printf("Could not send status response, error %d\n", err);
 					}
@@ -2082,8 +2089,9 @@ checkpoint:
 						free(src);
 						free(dst);
 					}
-
-					err = mobilebackup2_send_status_response(mobilebackup2, errcode, errdesc, plist_new_dict());
+					plist_t empty_dict = plist_new_dict();
+					err = mobilebackup2_send_status_response(mobilebackup2, errcode, errdesc, empty_dict);
+					plist_free(empty_dict);
 					if (err != MOBILEBACKUP2_E_SUCCESS) {
 						printf("Could not send status response, error %d\n", err);
 					}
-- 
cgit v1.1-32-gdbae