From 3dda9d2701a34f02058425eea25431122283177c Mon Sep 17 00:00:00 2001 From: Nikias Bassen Date: Thu, 1 Jul 2021 17:48:21 +0200 Subject: Use strcasecmp instead of copying and lower-casing string in irecv_devices_get_device_by_hardware_model() --- configure.ac | 2 +- src/libirecovery.c | 8 +------- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/configure.ac b/configure.ac index 7e8c7ea..d136f93 100644 --- a/configure.ac +++ b/configure.ac @@ -41,7 +41,7 @@ AC_TYPE_UINT32_T AC_TYPE_UINT8_T # Checks for library functions. -AC_CHECK_FUNCS([strdup strerror strndup malloc realloc calloc]) +AC_CHECK_FUNCS([strdup strerror strcasecmp strndup malloc realloc calloc]) # Checks for libraries. AC_CHECK_HEADERS([readline/readline.h], [], diff --git a/src/libirecovery.c b/src/libirecovery.c index 1defaac..2219f36 100644 --- a/src/libirecovery.c +++ b/src/libirecovery.c @@ -3271,14 +3271,8 @@ IRECV_API irecv_error_t irecv_devices_get_device_by_hardware_model(const char* h *device = NULL; - /* lowercase hardware_model string for proper lookup */ - char model[8]; - strcpy(model, hardware_model); - char *p = model; - for (; *p; ++p) *p = tolower(*p); - for (i = 0; irecv_devices[i].hardware_model != NULL; i++) { - if (!strcmp(model, irecv_devices[i].hardware_model)) { + if (!strcasecmp(hardware_model, irecv_devices[i].hardware_model)) { *device = &irecv_devices[i]; return IRECV_E_SUCCESS; } -- cgit v1.1-32-gdbae