bplist: Plug memory leaks caused by unused (and unfreed) buffer

When parsing binary plists with BPLIST_DICT or BPLIST_ARRAY nodes that are
referenced multiple times in a particular file, a buffer was allocated that
was not used, and also not freed, thus causing memory leaks.

1 files changed, 0 insertions, 5 deletions

diff --git a/src/bplist.c b/src/bplist.c
index cbe9481..5ddca26 100644
--- a/src/bplist.c
+++ b/src/bplist.c
@@ -584,14 +584,9 @@ static void* copy_plist_data(const void* src)
         dstdata->strval = strdup(srcdata->strval);
         break;
     case PLIST_DATA:
-    case PLIST_ARRAY:
         dstdata->buff = (uint8_t*) malloc(sizeof(uint8_t) * srcdata->length);
         memcpy(dstdata->buff, srcdata->buff, sizeof(uint8_t) * srcdata->length);
         break;
-    case PLIST_DICT:
-        dstdata->buff = (uint8_t*) malloc(sizeof(uint8_t) * srcdata->length * 2);
-        memcpy(dstdata->buff, srcdata->buff, sizeof(uint8_t) * srcdata->length * 2);
-        break;
     case PLIST_UID:
         dstdata->intval = srcdata->intval;
         break;