summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGravatar Nikias Bassen2017-01-28 04:55:59 +0100
committerGravatar Nikias Bassen2017-01-28 04:55:59 +0100
commit96ced4ea51df8d2816b5e0e97203be38949aa2b0 (patch)
treedca471e58d1a3fab9df77d06830b7fab7eea44cc
parent369d72bb954d0112c47af341ffff15d84228d3bb (diff)
downloadlibplist-96ced4ea51df8d2816b5e0e97203be38949aa2b0.tar.gz
libplist-96ced4ea51df8d2816b5e0e97203be38949aa2b0.tar.bz2
bplist: Improve writing of offset table
-rw-r--r--src/bplist.c15
1 files changed, 3 insertions, 12 deletions
diff --git a/src/bplist.c b/src/bplist.c
index 2121ef9..5a9d678 100644
--- a/src/bplist.c
+++ b/src/bplist.c
@@ -1163,18 +1163,9 @@ PLIST_API void plist_to_bin(plist_t plist, char **plist_bin, uint32_t * length)
buff_len = bplist_buff->len;
offset_size = get_needed_bytes(buff_len);
offset_table_index = bplist_buff->len;
- for (i = 0; i < num_objects; i++)
- {
- uint8_t *offsetbuff = (uint8_t *) malloc(offset_size);
-
-#ifdef __BIG_ENDIAN__
- offsets[i] = offsets[i] << ((sizeof(uint64_t) - offset_size) * 8);
-#endif
-
- memcpy(offsetbuff, &offsets[i], offset_size);
- byte_convert(offsetbuff, offset_size);
- byte_array_append(bplist_buff, offsetbuff, offset_size);
- free(offsetbuff);
+ for (i = 0; i < num_objects; i++) {
+ uint64_t offset = be64toh(offsets[i]);
+ byte_array_append(bplist_buff, (uint8_t*)&offset + (sizeof(uint64_t) - offset_size), offset_size);
}
//setup trailer