diff options
| author | 2020-12-21 22:09:42 -0800 | |
|---|---|---|
| committer | 2021-06-22 01:29:05 +0200 | |
| commit | b086d0612740978c1942c1c3a078d4a0b8ffffef (patch) | |
| tree | 46484950e8e6dbf2fb5d773a84b5bb73fc313bf7 /src/String.cpp | |
| parent | 526c10436caa894fb6139f4e6c0f73eebfa858ea (diff) | |
| download | libplist-b086d0612740978c1942c1c3a078d4a0b8ffffef.tar.gz libplist-b086d0612740978c1942c1c3a078d4a0b8ffffef.tar.bz2 | |
[clang-tidy] cpp: Replace free with delete
It's the C++ way. It also avoids having to check for NULL.
Found with cppcoreguidelines-owning-memory
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Diffstat (limited to 'src/String.cpp')
| -rw-r--r-- | src/String.cpp | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/src/String.cpp b/src/String.cpp index cd4f98f..06b61ba 100644 --- a/src/String.cpp +++ b/src/String.cpp | |||
| @@ -67,13 +67,8 @@ std::string String::GetValue() const | |||
| 67 | { | 67 | { |
| 68 | char* s = NULL; | 68 | char* s = NULL; |
| 69 | plist_get_string_val(_node, &s); | 69 | plist_get_string_val(_node, &s); |
| 70 | std::string ret; | 70 | std::string ret = s ? s : ""; |
| 71 | if (s) { | 71 | delete s; |
| 72 | ret = s; | ||
| 73 | free(s); | ||
| 74 | } else { | ||
| 75 | ret = ""; | ||
| 76 | } | ||
| 77 | return ret; | 72 | return ret; |
| 78 | } | 73 | } |
| 79 | 74 | ||
