summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-12-23plist: Improve plist_dict_next_item() drastically by iterating on node list ↵Gravatar Nikias Bassen1-10/+8
directly As Xiao Deng pointed out in #131, plist_dict_next_item() was very inefficient. For each iteration, node_nth_child() was called with the iterator value, which would walk through the child node list on EVERY iteration. If the dictionary is large this makes things very slow. More than that, after reaching the key node the code was calling node_nth_child() AGAIN (with iterator value + 1) to reach the value node, which would walk through the node list once more. This commit changes the iterator to be a node_t pointer so that the iteration is done on the node list directly.
2018-12-17xplist: Write base64 directly to output buffer to improve memory usageGravatar Nikias Bassen1-5/+2
Now that we grow the output buffer enough before writing XML output we can just write the base64 encoded data directly to the ouput buffer instead of using a heap buffer that will then be copied to the output buffer. This makes writing XML output more memory efficient (and slightly faster).
2018-12-17cython: Fix Node.to_bin() decodeGravatar Shane Garrett1-1/+1
Don't convert the string to UTF-8, just bytes. Fixes #109.
2018-12-14xplist: Improve memory usage by estimating output buffer sizeGravatar Nikias Bassen2-3/+128
2018-12-14xplist: Fix writing of empty dict and array nodes to XMLGravatar Nikias Bassen1-8/+6
2018-12-11xplist: Fix segfault caused by recent changes in libcnaryGravatar Nikias Bassen1-1/+1
2018-12-10ptrarray: Allow larger chunks for buffer reallocationGravatar Nikias Bassen1-1/+1
2018-12-10xplist: Prevent unnecessary reallocations when writing XML outputGravatar Nikias Bassen1-1/+4
2018-12-10Remove node_iterator and operate on node list directly to improve memory usageGravatar Nikias Bassen9-269/+7
2018-12-10bplist: Improve performance and memory usage when writing binary plistGravatar Nikias Bassen4-6/+88
2018-11-30bplist: Remove unnecessary allocations when parsing and writing unicode nodesGravatar Nikias Bassen1-88/+72
2018-11-29bplist: Remove redundant calls to strlen()Gravatar Nikias Bassen1-7/+4
2018-11-28libcnary: Remove redundant members from node_t structGravatar Nikias Bassen2-32/+17
2018-09-04xplist: Assert when number of child nodes of PLIST_DICT is not evenGravatar Nikias Bassen1-0/+3
This should only happen due to misuse of the library, e.g. when calling plist_free() on a node that is a value node in a PLIST_DICT without properly removing the dictionary entry (key/value pair) and then calling plist_to_xml() on that dictionary.
2018-07-25xplist: Fix typo in error messageGravatar Bastien Nocera1-1/+1
2018-07-24libcnary: Fix memleak in node_debug()Gravatar Bastien Nocera1-0/+1
An iter was created but never destroyed.
2017-06-08configure: Allow building with sanitizers (without fuzzers)Gravatar Nikias Bassen1-10/+35
Passing --with-sanitizers will enable building with available sanitizers. Passing --with-fuzzers will enable building fuzzers which will also imply --with-sanitizers.
2017-05-31bplist: Prevent store to misaligned address when writing real/date nodesGravatar Nikias Bassen1-9/+9
ASAN reported possible undefined behaviour when writing float/double values to misaligned addresses.
2017-05-31fuzz: Add some more crash samples reported via github issues.Gravatar Nikias Bassen15-0/+0
2017-05-30fuzz: Add crash/leak samples from OSS-FuzzGravatar Nikias Bassen16-0/+10299
2017-05-30fuzz: Move known crash/leak samples to per-fuzzer directoriesGravatar Nikias Bassen18-2/+2
2017-05-29fuzz: Add appropriate -max_len to fuzzers for testingGravatar Nikias Bassen1-2/+2
2017-05-29Prefer clang/clang++ over gcc/g++ (if installed)Gravatar Nikias Bassen1-0/+9
2017-05-29Integrate fuzzers into build systemGravatar Nikias Bassen6-1/+175
2017-05-29fuzz: Add some known previously crashing test casesGravatar Nikias Bassen17-0/+164
2017-05-29bplist: Work around misaligned reads reported by AddressSanitizerGravatar Nikias Bassen1-3/+3
These misaligned reads reported by ASAN might lead to undefined behavior.
2017-04-25Add fuzzing targets for libFuzzer used by Google's OSS-FuzzGravatar Nikias Bassen6-0/+122
2017-04-20Updated NEWS for release2.0.0Gravatar Nikias Bassen1-0/+30
2017-04-20Updated AUTHORS from commit historyGravatar Nikias Bassen1-1/+6
2017-04-20Bump version to 2.0.0 for releaseGravatar Nikias Bassen1-1/+1
2017-04-20Bump so version due to added functions to interfaceGravatar Nikias Bassen1-1/+1
2017-04-20build: Fix check for previously installed cython bindingsGravatar Nikias Bassen1-0/+1
Due to the removal of pkg-config check for libxml2, $PKG_CONFIG was not defined and a check for libplist's include dir via pkg-config failed. By invoking PKG_PROG_PKG_CONFIG $PKG_CONFIG will be defined and the check works again.
2017-04-20build: Make sure plist.pxd is included in tarballsGravatar Christophe Fergeau1-3/+2
When generating a tarball on a system without cython installed, plist.pxd was missing, causing build failures later on when trying to use cython. This seems to be caused by EXTRA_DIST being inside a if HAVE_CYTHON block rather than being outside of it.
2017-04-20autofoo: Ensure that 'make distcheck' doesn't fail when cython is not installedGravatar Christophe Fergeau2-6/+5
2017-04-20test: Rename dates.test output files so the get removed upon 'make distclean'Gravatar Christophe Fergeau1-2/+2
2017-04-20test: Add missing test files to Makefile.am/EXTRA_DISTGravatar Christophe Fergeau1-1/+42
2017-04-20bplist: Fix missing break in switch statement in plist_to_bin()Gravatar Nikias Bassen1-0/+1
Credit to Christophe Fergeau
2017-04-20bplist: Suppress compiler warnings with proper castsGravatar Nikias Bassen1-3/+3
2017-04-20cython: Remove references to libxml2 flags from Makefile.amGravatar Nikias Bassen1-2/+2
2017-04-20test: Fix wrong filename in EXTRA_DIST entry of Makefile.amGravatar Nikias Bassen1-1/+1
2017-04-19bplist: Fix integer overflow check (offset table size)Gravatar Nikias Bassen1-3/+17
2017-04-14Initialize safe_year in time64.cGravatar Greg Dennis1-2/+2
Clang fails with stricter compilation options, because it thinks safe_year may be uninitialized at the return statement. The logic prevents it from being uninitialized, but probably worth the initialization to avoid the compiler error. The rest of libimobiledevice compiles successfully under the same options.
2017-04-06Update time64_limits.hGravatar Greg Dennis1-0/+2
This depends on the 'tm' type being declared, which is defined in time.h.
2017-04-02xplist: Plug another memory leakGravatar Nikias Bassen1-0/+3
Credit to OSS-Fuzz
2017-03-29xplist: Prevent memory leak(s) when parsing failsGravatar Nikias Bassen1-2/+2
Credit to OSS-Fuzz
2017-03-29xplist: Make XML parsing non-recursive to prevent stack overflow on ↵Gravatar Nikias Bassen1-79/+103
deep-structured plists Credit to OSS-Fuzz
2017-03-28libcnary: Remove unused 'node' parameter from node_list_create()Gravatar Nikias Bassen3-3/+3
2017-03-26bplist: Make sure sanity checks work on 32bit platformsGravatar Nikias Bassen1-10/+14
Because on 32-bit platforms 32-bit pointers and 64-bit sizes have been used for the sanity checks of the offset table and object references, the range checks would fail in certain interger-overflowish situations, causing heap buffer overflows or other unwanted behavior. Fixed by wideing the operands in question to 64-bit.
2017-03-18autocconf: Add android exception for pthread detectionGravatar Nikias Bassen1-2/+2
2017-02-18base64: Prevent undefined shift when parsing invalid base64 encoded dataGravatar Nikias Bassen1-3/+3
Credit to OSS-Fuzz