summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2016-11-10bplist: Fix possible out-of-bounds read in parse_dict_node() with proper ↵Gravatar Filippo Bigarella1-2/+13
bounds checking
2016-10-31xplist: Prevent UaF when parsing structured nodes failstime64Gravatar Filippo Bigarella1-0/+5
In case parsing inside `node_from_xml` called from line 842 fails, `data` gets freed by the call to `plist_free` at line 899, since `subnode` is actually created by making it point to `data` at line 684. This commit prevents this situation by bailing out whenever parsing in a deeper level of structured nodes fails.
2016-10-31xplist: Prevent heap buffer overflow when parsing empty tagsGravatar Filippo Bigarella1-1/+3
If `ctx->pos - p - 1` is greater than `taglen`, we end up writing outside the buffer pointed to by `tag`. This commit fixes it by checking the bounds of the heap buffer before writing.
2016-10-31xplist: Prevent NULL pointer dereference when parsing <real> nodesGravatar Filippo Bigarella1-0/+8
2016-10-31base64: Prevent buffer overflow by not decoding blocks with less than 4 charsGravatar Filippo Bigarella1-1/+1
2016-10-24Add pthread detection to configure.ac to get cflags and libs rightGravatar Nikias Bassen3-2/+495
2016-10-22Remove libxml2 dependency in favor of custom XML parsingGravatar Nikias Bassen10-407/+798
2016-09-19test: Add additional test case to check extended date rangeGravatar Nikias Bassen3-0/+20
2016-09-19Use time64 implementation by Michael G Schwern to extend allowed date/time rangeGravatar Nikias Bassen6-12/+1061
The main benefit of this is to allow date/time values outside of the 32bit time_t range which is very important on 32bit platforms. But there are also some other issues that will be fixed with this, for example on macOS, mktime() will not work for dates < 1902 despite time_t being 64bit. In the same run this commit will also use a reentrant version of gmtime64_r that should help in multithreaded scenarios. Original code taken from: https://github.com/evalEmpire/y2038
2016-09-19Change internal storage of PLIST_DATE values from struct timeval to doubleGravatar Nikias Bassen4-36/+16
This removes the timeval union member from the plist_data_t structure. Since struct timeval is 2x64bit on 64bit platforms this member unnecessarily grew the union size to 16 bytes while a size of 8 bytes is sufficient. Also, on 32bit platforms struct timeval is only 2x32bit of size, limiting the range of possible time values. In addition the binary property list format also stores PLIST_DATE nodes as double.
2016-09-08Make sure plist_cleanup() symbol is actually publicGravatar Martin Szulecki1-1/+1
2016-06-29xplist: Plug memory leak when converting PLIST_UID nodes to XMLGravatar Nikias Bassen3-1/+3
In node_to_xml nodes of type PLIST_UID are temporarily converted to a PLIST_DICT for an appropriate XML output. Therefore a PLIST_KEY and a PLIST_UINT node is created and inserted into the PLIST_DICT node. Upon completion, the child nodes of the PLIST_DICT node are detached from the original node and freed, however the data of the child nodes - the key string and the uint value - are not. This commit fixes it.
2016-06-29test: Add another test case for signed/unsigned (multiple) integersGravatar Nikias Bassen4-0/+35
Apart from testing the actual integer signed vs. unsigned value storage and conversion, this test will check that the binary plist optimization is not re-using existing values. Basically it will test the fix that was introduced with commit acd226d1f71a78dd23b47a9a5c4ca8cf8068d509.
2016-06-29plist_data_compare: Make sure to compare the node sizes for integer nodesGravatar Nikias Bassen1-0/+2
Without this check, e.g. the values -1 and 18446744073709551615 would yield in a match, since the comparison will just compare the uint64_t values. However, any value >= 9223372036854775808 and <= 18446744073709551615 is stored as a 128 bit value in binary plist format to make sure it is recognized as an unsigned value. We store it internally as a uint64_t value, but we set the size to 16 vs. 8 accordingly; so this commit will make sure the binary plist optimization will not re-use matching uint64_t values of actually mismatching signed/unsigned values.
2016-05-12Implement plist_from_memory()Gravatar Christophe Fergeau2-0/+26
Rather than having everyone reimplement binary/XML plist detection by looking at the first bytes of the plist content, it's better to do this detection in libplist and hide that internal detail from library users.
2016-05-12Add plist_is_binary()Gravatar Christophe Fergeau2-0/+22
It can be useful if one needs to know what type of plist a memory buffer contains.
2016-05-12Allow to run autogen.sh outside $top_srcdirGravatar Christophe Fergeau1-11/+18
This makes it more convenient to do builds out of the source dir.
2016-05-12bplist: Speed up plist_to_bin conversion for large plistsGravatar Nikias Bassen3-9/+12
Using a better hashing algorithm and a larger hash table the conversion is A LOT faster when processing large plists. Thanks to Xiao Deng for reporting this issue and suggesting a fix.
2016-04-20Move libxml cleanup code to a plist_cleanup methodGravatar Frederik Carlier3-17/+31
2016-04-20cython: Fix module build with libplist already installedGravatar Elan Ruusamäe1-1/+1
see https://github.com/pld-linux/libplist/commit/a4a4e4b04caef3f9875b598d64ffb1fb388e699e
2015-12-07Node.cpp: let plist_t operations free _node when in a container.Gravatar Aaron Burghardt1-1/+6
Fixes libimobiledevice/libplist#50.
2015-11-13xplist: Get rid of setlocale() and use custom function to print floating ↵Gravatar Nikias Bassen1-14/+32
point values
2015-02-05test: Add missing .test filesGravatar Nikias Bassen3-0/+35
2015-02-05test: Add more test cases covering binary plist issuesGravatar Nikias Bassen5-2/+32
2015-02-05bplist: Refactor binary plist parsing in a recursive wayGravatar Nikias Bassen1-209/+167
2015-01-31bplist: Plug memory leaks caused by unused (and unfreed) bufferGravatar Nikias Bassen1-5/+0
When parsing binary plists with BPLIST_DICT or BPLIST_ARRAY nodes that are referenced multiple times in a particular file, a buffer was allocated that was not used, and also not freed, thus causing memory leaks.
2015-01-31bplist: Fix possible crash in plist_from_bin() caused by access to already ↵Gravatar Nikias Bassen1-3/+5
freed memory Given a specifically ordered binary plist the function plist_from_bin() would free BPLIST_DICT or BPLIST_ARRAY raw node data that is still required for parsing of following nodes. This commit addresses this issues by moving the memory free to the end of the parsing process.
2015-01-29m4: Acutally report include path check before doing the checkGravatar Martin Szulecki1-1/+1
2015-01-29m4: Use python-config if available to fix Python 3 support on newer distrosGravatar Martin Szulecki1-0/+6
2015-01-29plistutil: Plug some memory leaksGravatar Nikias Bassen1-2/+6
2015-01-29plistutil: Use static buffer for stat()Gravatar Nikias Bassen1-6/+4
2015-01-29Move pkg-config file into src directoryGravatar Martin Szulecki5-5/+5
2015-01-29Improve maintainability and Requires of pkg-config files slightlyGravatar Martin Szulecki2-9/+7
2015-01-28Require autoconf 2.64+ to use package bugreport and project URL in AC_INITGravatar Martin Szulecki1-2/+2
2015-01-28Update README with new git URL, IRC and twitter profileGravatar Martin Szulecki1-2/+5
2015-01-23xplist: Plug memory leak by cleaning up libxml2's parser after useGravatar Martin Szulecki1-0/+16
This is actually considered bad practice. However, it appears this memory leak is otherwise not possible to fix due to a design flaw in how libxml2 handles the lifecycle of it's XML parser. We'll let the community test this in production now and decide. In our tests this change had no drawbacks except fixing the last known memory leak in libplist.
2015-01-23plistutil: Improve error message for a human if input file reading failedGravatar Martin Szulecki1-1/+1
2015-01-23plistutil: Cleanup code style a bit and remove obsolete extra headerGravatar Martin Szulecki3-102/+79
2015-01-23Update and correct some copyright header commentsGravatar Martin Szulecki3-3/+8
2015-01-23xplist: Fix limited but possible XXE security vulnerability with XML plistsGravatar Martin Szulecki1-4/+16
By using a specifically crafted XML file an attacker could use plistutil to issue a GET request to an arbitrary URL or disclose a local file. The crafted XML file would be using a custom DTD with an external entity reference pointing to the file. Practical abuse is limited but let's still fix it nevertheless. Related to CVE-2013-0339 for libxml2 and CWE-827. Reported by Loïc Bénis from calypt.com. Thanks!
2015-01-23Add generation of documentation using "make docs"Gravatar Martin Szulecki2-2/+10
2015-01-11Pass flag '-avoid-version' to libtool for libplist++ in addition to libplist ↵Gravatar Aaron Burghardt1-0/+1
for WIN32.
2014-10-22Workaround autoconf bug and ensure a C++ compiler is mandatoryGravatar Martin Szulecki1-0/+10
If AC_PROG_CXX is used after AC_PROG_CC, it will return "g++" even if no C++ compiler is installed. However, as we need one, testing compiling a program will make configure fail if indeed no C++ compiler is installed.
2014-10-14Post-release version bump to 1.13Gravatar Martin Szulecki1-1/+1
2014-10-14Add "check-news" automake option to ensure correct NEWS file on releases1.12Gravatar Martin Szulecki1-1/+1
2014-10-14cython: Enforce default symbol visibility to make bindings loadableGravatar Martin Szulecki1-1/+1
2014-10-14cython: Use output variables instead of relative paths in MakefileGravatar Martin Szulecki1-2/+2
2014-10-14Update NEWS with latest changesGravatar Martin Szulecki1-0/+24
2014-10-14Bump so name correctly as some ABI symbols were removedGravatar Martin Szulecki1-1/+1
2014-10-09bplist: Fix plist_from_bin() changing value nodes to key nodes in dictionariesGravatar Martin Szulecki1-11/+33
The parsing logic for binary dictionaries wrongly enforced the key type even on nodes that were already parsed as value nodes. This caused the resulting plist_t node tree to have key nodes instead of value nodes within dictionaries for some valid binary plists. This commit should also generally fixes parsing of binary plist files which use an efficient dictionary reference table.
© 2009-2020 sukimashita.com - Generated by cgit - Icons from Tango - Uses Google Analytics