Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2016-11-10 | bplist: Make sure to error out if allocation of `used_indexes` buffer in ↵ | Filippo Bigarella | 1 | -0/+6 | |
plist_from_bin() fails If the allocation fails, a lot of bad things can happen so we check the result and return accordingly. We also check that the multiplication used to calculate the buffer size doesn't overflow. Otherwise this could lead to an allocation of a very small buffer compared to what we need, ultimately leading to arbitrary writes later on. | |||||
2016-11-10 | bplist: Prevent out-of-bounds read in plist_from_bin() when parsing offset_table | Filippo Bigarella | 1 | -1/+9 | |
offset_table_index is read from the file, so we have full control over it. This means we can point offset_table essentially anywhere we want, which can lead to an out-of-bounds read when it will be used later on. | |||||
2016-11-10 | bplist: Make sure the index in parse_bin_node_at_index() is actually within ↵ | Filippo Bigarella | 1 | -4/+13 | |
the offset table | |||||
2016-11-10 | bplist: Fix possible out-of-bounds reads in parse_bin_node() with proper ↵ | Filippo Bigarella | 1 | -0/+21 | |
bounds checking | |||||
2016-11-10 | bplist: Fix possible out-of-bounds read in parse_dict_node() with proper ↵ | Filippo Bigarella | 1 | -2/+13 | |
bounds checking | |||||
2016-10-22 | Remove libxml2 dependency in favor of custom XML parsing | Nikias Bassen | 1 | -2/+1 | |
2016-09-19 | Change internal storage of PLIST_DATE values from struct timeval to double | Nikias Bassen | 1 | -9/+2 | |
This removes the timeval union member from the plist_data_t structure. Since struct timeval is 2x64bit on 64bit platforms this member unnecessarily grew the union size to 16 bytes while a size of 8 bytes is sufficient. Also, on 32bit platforms struct timeval is only 2x32bit of size, limiting the range of possible time values. In addition the binary property list format also stores PLIST_DATE nodes as double. | |||||
2016-05-12 | bplist: Speed up plist_to_bin conversion for large plists | Nikias Bassen | 1 | -4/+7 | |
Using a better hashing algorithm and a larger hash table the conversion is A LOT faster when processing large plists. Thanks to Xiao Deng for reporting this issue and suggesting a fix. | |||||
2015-02-05 | bplist: Refactor binary plist parsing in a recursive way | Nikias Bassen | 1 | -209/+167 | |
2015-01-31 | bplist: Plug memory leaks caused by unused (and unfreed) buffer | Nikias Bassen | 1 | -5/+0 | |
When parsing binary plists with BPLIST_DICT or BPLIST_ARRAY nodes that are referenced multiple times in a particular file, a buffer was allocated that was not used, and also not freed, thus causing memory leaks. | |||||
2015-01-31 | bplist: Fix possible crash in plist_from_bin() caused by access to already ↵ | Nikias Bassen | 1 | -3/+5 | |
freed memory Given a specifically ordered binary plist the function plist_from_bin() would free BPLIST_DICT or BPLIST_ARRAY raw node data that is still required for parsing of following nodes. This commit addresses this issues by moving the memory free to the end of the parsing process. | |||||
2014-10-09 | bplist: Fix plist_from_bin() changing value nodes to key nodes in dictionaries | Martin Szulecki | 1 | -11/+33 | |
The parsing logic for binary dictionaries wrongly enforced the key type even on nodes that were already parsed as value nodes. This caused the resulting plist_t node tree to have key nodes instead of value nodes within dictionaries for some valid binary plists. This commit should also generally fixes parsing of binary plist files which use an efficient dictionary reference table. | |||||
2014-10-03 | Drop src/common.h and use byte order macros from config.h directly | Nikias Bassen | 1 | -11/+14 | |
2014-10-03 | Avoid exporting non-public symbols | Nikias Bassen | 1 | -2/+2 | |
2014-09-23 | bplist: Prevent crash in plist_from_bin() when parsing unusually structured ↵ | Nikias Bassen | 1 | -1/+1 | |
binary plist | |||||
2014-08-25 | Fixed memory leaks in new_xml_plist() and parse_real_node(). | Aaron Burghardt | 1 | -0/+1 | |
2014-08-06 | bplist: Silence compiler warning about 'always true' comparison due to type ↵ | Nikias Bassen | 1 | -2/+6 | |
mismatch | |||||
2014-05-23 | Handle signed vs. unsigned integer values correctly | Nikias Bassen | 1 | -2/+25 | |
2014-05-18 | bplist: Fix memory leaking caused by unused nodes in plist_from_bin() | Nikias Bassen | 1 | -0/+9 | |
2014-02-06 | bplist: prevent segmentation fault in plist_from_bin() | Nikias Bassen | 1 | -0/+3 | |
2013-12-13 | bplist: make plist_utf8_to_utf16 static since it is only used internally | Nikias Bassen | 1 | -1/+1 | |
2013-10-17 | UTF-16 surrogate pair fix | shane | 1 | -4/+37 | |
Handle UTF-16 surrogate pair conversion to/from UTF-8 | |||||
2013-05-30 | bplist: use __FLOAT_WORD_ORDER__ instead of __VFP_FP__ for floating point ↵ | Nikias Bassen | 1 | -1/+4 | |
endianness detection | |||||
2012-09-16 | implemented handling of UID keyed encoding type | Nikias Bassen | 1 | -2/+58 | |
2012-02-11 | bplist: fix invalid memory access in copy_plist_data | Nikias Bassen | 1 | -4/+4 | |
2012-01-12 | fix compiler warnings | Nikias Bassen | 1 | -8/+0 | |
2011-05-28 | define be16toh, be32toh, be64toh if not available | Nikias Bassen | 1 | -0/+34 | |
2011-05-27 | Make libplist glib free | Nikias Bassen | 1 | -127/+212 | |
2011-03-16 | Plugging memory leak in write_unicode | Christophe Fergeau | 1 | -0/+1 | |
2010-07-29 | Fix unicode binary writing. | Jonathan Beck | 1 | -7/+23 | |
2010-04-18 | Endianness, alignment and type-punning fixes for binary plist support | Julien BLACHE | 1 | -13/+63 | |
- endianness issues: on big endian machines, writing out only part of an integer was broken (get_needed_bytes(x) < sizeof(x)) -> shift integer before memcpy() on big endian machines - alignment issues: unaligned reads when loading binary plist. Leads to slow runtime performance (kernel trapping and fixing things up), SIGBUS (kernel not helping us out) -> introduce get_unaligned() and have the compiler generate the code needed for the unaligned access (note that there remains unaligned accesses that I haven't been able to track down - I've seen 2 of them with test #2) - type-punning issues: breaking strict aliasing rules can lead to unexpected results as the compiler takes full advantage of the aliasing while optimizing -> introduce the plist_uint_ptr union instead of casting pointers Tested on amd64, alpha and hppa. | |||||
2010-03-24 | Fix armel floating point endianess (LP: #541879) | Alexander Sack | 1 | -6/+26 | |
* on armel system floating poing data can have different endianess than rest of types; hence we fix arm endianess for defined(__VFP_FP__) to be big/native; this also applies for data parsing/writing * date parsing didnt flip the endianess back for little endian systems when reading the values causing test failures; we fix this by ensuring float endianess is applied when parsing | |||||
2010-01-21 | Fix some warnings | Jonathan Beck | 1 | -3/+2 | |
2009-10-28 | Format sources to ANSI style using AStyle (astyle --style=ansi). | Jonathan Beck | 1 | -704/+741 | |
2009-10-28 | Fix build for MSVC9. | Jonathan Beck | 1 | -1/+1 | |
2009-09-06 | Fix boolean length in binary parsing | Jonathan Beck | 1 | -0/+2 | |
2009-07-08 | Add a deep copy function and value setters for nodes. | Jonathan Beck | 1 | -12/+11 | |
2009-04-28 | Merge ascii and unicode handling in PLIST_STRING using UTF-8. Remove unicode ↵ | Jonathan Beck | 1 | -19/+41 | |
related declaration in API (breaks API&ABI) | |||||
2009-04-27 | Fix compiler pointer assignment warnings | Martin Szulecki | 1 | -3/+3 | |
2009-02-15 | Do not write 3 byte integer nodes. Use standard 4bytes integer instead. | Jonathan Beck | 1 | -1/+5 | |
2009-02-15 | Add more regression test and fix Integer and Real type handling. | Jonathan Beck | 1 | -64/+16 | |
2009-02-14 | Fix more memory leaks. | Jonathan Beck | 1 | -0/+7 | |
2009-02-14 | Fix some memory leaks. | Jonathan Beck | 1 | -0/+1 | |
2009-02-14 | Fix binary dict indexes. | Jonathan Beck | 1 | -2/+2 | |
2009-02-09 | Add support for 3 bytes offsets. | Jonathan Beck | 1 | -2/+12 | |
2009-02-09 | Make it compile on MSVC 2005. | Jonathan Beck | 1 | -44/+83 | |
2009-01-29 | Fix indent. | Jonathan Beck | 1 | -6/+6 | |
2009-01-29 | Add setter and getter for Date and Unicode types. | Jonathan Beck | 1 | -0/+10 | |
2009-01-29 | Clean some old stuff. | Jonathan Beck | 1 | -11/+0 | |
2009-01-29 | Add some static declarations. | Jonathan Beck | 1 | -1/+3 | |