summaryrefslogtreecommitdiffstats
path: root/src/bplist.c
AgeCommit message (Collapse)AuthorFilesLines
4 daysbytearray: Handle realloc() failure in byte_array_grow()Gravatar Comtea041-0/+7
byte_array_grow() assigned the result of realloc() directly to ba->data and increased the capacity even if realloc() failed, so the following memcpy() in byte_array_append() wrote to NULL + len. On failure, free the old buffer and leave the byte array in a failed state (data == NULL), which byte_array_append() already ignores. The callers check for that state: - the writers (bin, xml, json, openstep and the text output formats) return PLIST_ERR_NO_MEM instead of handing out a NULL/truncated buffer - node_to_xml() base64-encodes <data> directly into the grown buffer, so it must bail out there (only guarded by assert() before) - the OpenStep parser returns PLIST_ERR_NO_MEM for <hex data> instead of silently returning truncated data Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
7 daysptrarray: Handle realloc() failure in ptr_array_insert()Gravatar Comtea041-2/+7
ptr_array_insert() assigned the result of realloc() directly to pa->pdata and bumped the capacity without checking for failure, so on out-of-memory the old buffer was leaked and the following store or memmove() wrote through a NULL pointer. Keep the old buffer on failure and return -1 from ptr_array_insert() and ptr_array_add(). The callers now handle the error: - the array lookup cache (plist.c) is dropped instead of silently going out of sync with the node list; lookups then fall back to walking the children, as they do before the cache exists - bplist parsing (used_indexes) and serialization (objects) return PLIST_ERR_NO_MEM; ignoring the error in parse_bin_node_at_index() would otherwise loop forever since the array never grows Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-05-22bplist: Use format macro to use correct format in error messageGravatar Nikias Bassen1-1/+1
2026-02-12bplist: Add overflow check to node offset pointer arithmeticGravatar Nikias Bassen1-1/+7
Credit to OSSFuzz
2026-02-12Add NULL checks across codebaseGravatar Nikias Bassen1-5/+59
2026-01-22bplist: Fix compiler warning with explicit castGravatar Nikias Bassen1-1/+1
Credit to @ylwango613
2026-01-21bplist: Fix is_ascii_string by using sufficiently large data typeGravatar Nikias Bassen1-11/+10
Fixes #285 Credit to @ylwango613 for reporting.
2026-01-21bplist: Fix UTF-8 to UTF-16 decoding and enforce strict validationGravatar Nikias Bassen1-54/+69
- Treat input as unsigned bytes - Correct UTF-8 bit decoding for 2/3/4-byte sequences - Add overlong, surrogate, and range checks - Enforce lead/continuation byte constraints This addresses issue #283. Credit to @hgarrereyn for reporting.
2026-01-17plistutil: Use proper error description for new error codesGravatar Nikias Bassen1-1/+1
2026-01-17Prevent deep nesting of plist structures in all input/output formatsGravatar Nikias Bassen1-4/+22
Thanks to @unbengable12 for reporting. Addresses #288, #289, #290, #291, and #292.
2026-01-14bplist: Fix format specifier in debug messageGravatar Nikias Bassen1-1/+1
2026-01-14Add circular reference detection to all format writersGravatar Nikias Bassen1-13/+51
Thanks to @LkkkLxy for pointing out the issue.
2025-12-08bplist: Fix offset_table range checkGravatar Nikias Bassen1-1/+8
Credit to OSS-Fuzz
2025-10-29Use sufficiently large data type for indexes/position countersGravatar Nikias Bassen1-11/+11
2024-11-29Add missing cast in UINT_TO_HOSTGravatar Duncan Ogilvie1-2/+2
2024-11-28Fix compilation on MSVCGravatar Duncan Ogilvie1-9/+57
2024-11-28Switch from detecting little endian (common) to detecting big endian (rare)Gravatar Duncan Ogilvie1-7/+5
This prevents a bug class where we bswap things when __LITTLE_ENDIAN__ is not defined. Almost all modern systems are little endian, so detecting __BIG_ENDIAN__ is a better strategy.
2024-01-29Fix PLIST_API definitionsGravatar Nikias Bassen1-1/+1
2023-05-21Add explicit casts and fix return type mismatchesGravatar Nikias Bassen1-10/+12
2023-05-14bplist: Move realloc from parse_unicode_node() into plist_utf16be_to_utf8()Gravatar Nikias Bassen1-11/+12
It is very confusing to handle the reallocation (buffer shrinking) outside of the actual conversion function.
2023-05-13Move PLIST_API to the headersGravatar Nikias Bassen1-2/+2
2023-04-21bplist: Fix offset range checkGravatar Nikias Bassen1-1/+1
Credit to OSS-Fuzz
2023-02-07Fix build without --enable-debugGravatar Nikias Bassen1-0/+2
2023-02-07Add function to interface to allow enabling/disabling error/debug output for ↵Gravatar Nikias Bassen1-0/+5
the format parses This makes the `-d` option work in plistutil that wasn't doing anything
2023-02-06libcnary: Updated typedefs of node_t and node_list_t to contain pointerGravatar Nikias Bassen1-8/+8
This makes the code more readable. Obviously all the code that uses it is also updated.
2023-01-31bplist: Fix handling of PLIST_NULL node typeGravatar Nikias Bassen1-0/+1
2023-01-16Rename PLIST_UINT to PLIST_INT and add plist_new_int() and plist_get_int_val()Gravatar Nikias Bassen1-12/+12
This properly supports getting and setting signed or unsigned integer values. Also, a new helper function plist_int_val_is_negative() was added to determine if a given #PLIST_INT node has a negative value or not. The old type PLIST_UINT is defined as a macro with the value of PLIST_INT for backwards compatibility. This commit also adds int vs. uint support to the C++ interface, and the python bindings in a hopefully useful way.
2022-09-05Get rid of casting a ptr to a 32 bit valueGravatar Dave MacLachlan1-2/+2
This causes a warning if `-Wbad-function-cast` is enabled on a build.
2022-08-24bplist: Fix strict aliasing violationsGravatar Matthew Smith1-3/+9
Casting a float pointer to an int pointer is a strict aliasing violation (-Wstrict-aliasing) and is undefined behaviour (although, it did not seem to cause any real issues). An optimising compiler should elide the memcopies added by this commit.
2021-12-22Add a return value to plist_to_* and plist_from_* functionsGravatar Nikias Bassen1-15/+45
This way it can be easier determined why an import/export operation failed instead of just having a NULL result.
2021-12-19Add support for PLIST_NULL typeGravatar Nikias Bassen1-0/+12
2021-12-19Add new plist_mem_free() functionGravatar Nikias Bassen1-5/+0
Thanks to @azerg for bringing this to my attention. Instead of having multiple (internally identical) plist_*_free() functions, this commit introduces a single plist_mem_free() that can be used to free the memory allocated by plist_to_xml(), plist_to_bin(), plist_get_key_val(), plist_get_string_val(), and plist_get_data_val(). Note: This commit REMOVES plist_to_bin_free() and plist_to_xml_free().
2020-11-24Add parentheses to macros for better readabilityGravatar Rosen Penev1-14/+14
[clang-tidy] Found with bugprone-macro-parentheses Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-11-21bplist: Fix offset table range check, don't rely on pointer overflowGravatar Nikias Bassen1-1/+1
2020-06-08Remove whitespace errors from all filesGravatar Martin Szulecki1-1/+1
2020-06-03Remove pointless return in void functionsGravatar Rosen Penev1-2/+0
[clang-tidy] Found with readability-redundant-control-flow Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-05-14bplist: Prevent 32bit compiler warningGravatar Nikias Bassen1-1/+3
2020-05-11bplist: Remove unnecessary allocation and unused variablesGravatar Nikias Bassen1-10/+5
2019-12-09bplist: Silence compiler warningGravatar Nikias Bassen1-2/+2
2019-12-09bplist: Add cast to/from uint32_t when reading/storing indices for recursion ↵Gravatar Nikias Bassen1-4/+4
check
2019-12-09bplist: use ptr_array instead of PLIST_ARRAY to store node indices for ↵Gravatar XD1-10/+10
recursing check This improves performance by at least 30% for large files, and also reduces the memory footprint.
2019-11-07Add plist_to_bin_free() and plist_to_xml_free() functions that free memory ↵Gravatar Nikias Bassen1-0/+5
allocated by plist_to_bin()/plist_to_xml()
2019-01-18bplist: Silence compiler warning 'comparison is always true ...' (32 bit)Gravatar Nikias Bassen1-1/+1
2018-12-10Remove node_iterator and operate on node list directly to improve memory usageGravatar Nikias Bassen1-4/+1
2018-12-10bplist: Improve performance and memory usage when writing binary plistGravatar Nikias Bassen1-2/+84
2018-11-30bplist: Remove unnecessary allocations when parsing and writing unicode nodesGravatar Nikias Bassen1-88/+72
2018-11-29bplist: Remove redundant calls to strlen()Gravatar Nikias Bassen1-7/+4
2017-05-31bplist: Prevent store to misaligned address when writing real/date nodesGravatar Nikias Bassen1-9/+9
ASAN reported possible undefined behaviour when writing float/double values to misaligned addresses.
2017-05-29bplist: Work around misaligned reads reported by AddressSanitizerGravatar Nikias Bassen1-3/+3
These misaligned reads reported by ASAN might lead to undefined behavior.
2017-04-20bplist: Fix missing break in switch statement in plist_to_bin()Gravatar Nikias Bassen1-0/+1
Credit to Christophe Fergeau
© 2009-2026 sukimashita.com - Generated by cgit - Icons from Tango - Uses Google Analytics