Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2017-01-19 | bplist: Check for invalid ref_size in bplist trailer | Nikias Bassen | 1 | -0/+3 | |
2017-01-19 | bplist: Mass-rename 'dict_size' and 'param_dict_size' to more appropriate ↵ | Nikias Bassen | 1 | -30/+30 | |
'ref_size' | |||||
2017-01-19 | bplist: Use proper struct for binary plist trailer | Nikias Bassen | 1 | -47/+31 | |
2017-01-19 | bplist: Check for invalid offset_size in bplist trailer | Wang Junjie | 1 | -0/+3 | |
2017-01-18 | bplist: Improve UINT_TO_HOST macro, remove uint24_from_be function | Nikias Bassen | 1 | -17/+11 | |
The uint24_from_be function used memcpy and a call to byte_convert. Instead the macro now shifts the data appropriately with a new beNtoh macro that eventually uses be64toh. This commit also fixes the problem where binary plist data with other non-power-of-2 sizes (like 5,6, or 7) where not handled correctly, and actually supports sizes larger than 8 bytes though only the last 8 bytes are actually converted (nobody will come up with such a large plist anyway). | |||||
2017-01-16 | bplist: Disallow key nodes with non-string node types | Nikias Bassen | 1 | -0/+7 | |
As reported in #86, the binary plist parser would force the type of the key node to be of type PLIST_KEY while the node might be of a different i.e. non-string type. A following plist_free() might then call free() on an invalid pointer; e.g. if the node is of type integer, its value would be considered a pointer, and free() would cause an error. We prevent this issue by disallowing non-string key nodes during parsing. | |||||
2017-01-11 | base64: Rework base64decode to handle split encoded data correctly | Nikias Bassen | 1 | -41/+27 | |
2017-01-03 | xplist: Refine XML parsing error messages | Nikias Bassen | 1 | -15/+18 | |
2017-01-03 | time64: Remove some unused (and non-thread-safe) functions | Nikias Bassen | 2 | -28/+0 | |
2017-01-03 | win32: Try to prevent linking against libgcc_s_dw2 | Nikias Bassen | 1 | -2/+2 | |
While this works for libplist.dll, libplist++.dll will still have the _Unwind_Resume symbol being imported from libgcc_s_dw2-1.dll and there doesn't seem to be a way to prevent that. | |||||
2017-01-02 | xplist: Error out when invalid tags inside text nodes are encountered | Nikias Bassen | 1 | -2/+12 | |
2017-01-02 | xplist: Make sure to error out when encountering empty/incomplete entities | Nikias Bassen | 1 | -1/+5 | |
2017-01-02 | xplist: Make sure to not parse for entities in empty strings | Nikias Bassen | 1 | -1/+1 | |
2017-01-02 | xplist: Allow empty keys in dictionaries | Nikias Bassen | 1 | -2/+2 | |
2017-01-02 | xplist: Allow whitespace after name in closing tag | Nikias Bassen | 1 | -2/+7 | |
'</key >' is a perfectly valid closing tag and so is '</key >' (note the newline). This commit will make the parser skip any encountered whitespace before checking for the closing '>'. | |||||
2017-01-01 | xplist: Fix numerical character entity conversion | Nikias Bassen | 1 | -2/+6 | |
2016-12-21 | xplist: Fix UaF in code checking for closing tag | Nikias Bassen | 1 | -2/+2 | |
2016-12-21 | xplist: Make sure to correctly parse for closing tags of structured nodes | Nikias Bassen | 1 | -7/+45 | |
2016-12-21 | xplist: Make sure to stop parsing on entity errors | Nikias Bassen | 1 | -7/+11 | |
2016-12-14 | xplist: Remove usage of strlen() wherever possible | Nikias Bassen | 1 | -45/+66 | |
2016-12-14 | xplist: Improve text content parsing, reducing memory usage and unneeded copying | Nikias Bassen | 1 | -113/+318 | |
2016-12-14 | Properly check for the availability of strptime() and make sure to use it | Nikias Bassen | 1 | -1/+5 | |
2016-12-14 | base64: Prevent use of strlen() in base64decode when input buffer size is known | Nikias Bassen | 1 | -7/+8 | |
2016-11-28 | xplist: Fix parsing of adjacent nodes without whitespace between them | Nikias Bassen | 1 | -2/+1 | |
The context position counter was increased after encountering a closing node, e.g. '</dict>' or after a closing '</key>' node. When a node followed it directly without any whitespace inbetween, e.g. </dict><key>, parsing would fail since the parser would look at 'key>' instead of '<key>' for the next node to be parsed. | |||||
2016-11-27 | plist_copy: Duplicate hash tables when copying PLIST_DICT nodes | Nikias Bassen | 1 | -5/+15 | |
2016-11-18 | bplist: Remove misleading/redundant `else` from BPLIST_DATE case in ↵ | Nikias Bassen | 1 | -4/+3 | |
parse_bin_node | |||||
2016-11-18 | Improve plist_dict_set_item performance for large dictionaries with hash table | Nikias Bassen | 5 | -18/+119 | |
2016-11-13 | xplist: Don't parse XML reserved characters in CDATA blocks | Nikias Bassen | 1 | -0/+1 | |
2016-11-13 | bplist: Fix surrogate parsing range to include U+100000 - U+1FFFFF | Nikias Bassen | 1 | -2/+2 | |
2016-11-13 | xplist: Support converting numerical character entities | Nikias Bassen | 1 | -3/+51 | |
2016-11-13 | xplist: Don't escape " and ' characters in node_to_xml | Nikias Bassen | 1 | -10/+0 | |
2016-11-13 | xplist: Properly parse CDATA blocks in get_text_content() | Nikias Bassen | 1 | -7/+23 | |
2016-11-10 | Remove libxml2 private requirement from pkg-config control file | Nikias Bassen | 1 | -1/+0 | |
2016-11-10 | bplist: Make sure to error out if allocation of `used_indexes` buffer in ↵ | Filippo Bigarella | 1 | -0/+6 | |
plist_from_bin() fails If the allocation fails, a lot of bad things can happen so we check the result and return accordingly. We also check that the multiplication used to calculate the buffer size doesn't overflow. Otherwise this could lead to an allocation of a very small buffer compared to what we need, ultimately leading to arbitrary writes later on. | |||||
2016-11-10 | bplist: Prevent out-of-bounds read in plist_from_bin() when parsing offset_table | Filippo Bigarella | 1 | -1/+9 | |
offset_table_index is read from the file, so we have full control over it. This means we can point offset_table essentially anywhere we want, which can lead to an out-of-bounds read when it will be used later on. | |||||
2016-11-10 | bplist: Make sure the index in parse_bin_node_at_index() is actually within ↵ | Filippo Bigarella | 1 | -4/+13 | |
the offset table | |||||
2016-11-10 | bplist: Fix possible out-of-bounds reads in parse_bin_node() with proper ↵ | Filippo Bigarella | 1 | -0/+21 | |
bounds checking | |||||
2016-11-10 | bplist: Fix possible out-of-bounds read in parse_dict_node() with proper ↵ | Filippo Bigarella | 1 | -2/+13 | |
bounds checking | |||||
2016-10-31 | xplist: Prevent UaF when parsing structured nodes failstime64 | Filippo Bigarella | 1 | -0/+5 | |
In case parsing inside `node_from_xml` called from line 842 fails, `data` gets freed by the call to `plist_free` at line 899, since `subnode` is actually created by making it point to `data` at line 684. This commit prevents this situation by bailing out whenever parsing in a deeper level of structured nodes fails. | |||||
2016-10-31 | xplist: Prevent heap buffer overflow when parsing empty tags | Filippo Bigarella | 1 | -1/+3 | |
If `ctx->pos - p - 1` is greater than `taglen`, we end up writing outside the buffer pointed to by `tag`. This commit fixes it by checking the bounds of the heap buffer before writing. | |||||
2016-10-31 | xplist: Prevent NULL pointer dereference when parsing <real> nodes | Filippo Bigarella | 1 | -0/+8 | |
2016-10-31 | base64: Prevent buffer overflow by not decoding blocks with less than 4 chars | Filippo Bigarella | 1 | -1/+1 | |
2016-10-24 | Add pthread detection to configure.ac to get cflags and libs right | Nikias Bassen | 1 | -1/+1 | |
2016-10-22 | Remove libxml2 dependency in favor of custom XML parsing | Nikias Bassen | 8 | -385/+780 | |
2016-09-19 | Use time64 implementation by Michael G Schwern to extend allowed date/time range | Nikias Bassen | 5 | -11/+1034 | |
The main benefit of this is to allow date/time values outside of the 32bit time_t range which is very important on 32bit platforms. But there are also some other issues that will be fixed with this, for example on macOS, mktime() will not work for dates < 1902 despite time_t being 64bit. In the same run this commit will also use a reentrant version of gmtime64_r that should help in multithreaded scenarios. Original code taken from: https://github.com/evalEmpire/y2038 | |||||
2016-09-19 | Change internal storage of PLIST_DATE values from struct timeval to double | Nikias Bassen | 4 | -36/+16 | |
This removes the timeval union member from the plist_data_t structure. Since struct timeval is 2x64bit on 64bit platforms this member unnecessarily grew the union size to 16 bytes while a size of 8 bytes is sufficient. Also, on 32bit platforms struct timeval is only 2x32bit of size, limiting the range of possible time values. In addition the binary property list format also stores PLIST_DATE nodes as double. | |||||
2016-09-08 | Make sure plist_cleanup() symbol is actually public | Martin Szulecki | 1 | -1/+1 | |
2016-06-29 | xplist: Plug memory leak when converting PLIST_UID nodes to XML | Nikias Bassen | 3 | -1/+3 | |
In node_to_xml nodes of type PLIST_UID are temporarily converted to a PLIST_DICT for an appropriate XML output. Therefore a PLIST_KEY and a PLIST_UINT node is created and inserted into the PLIST_DICT node. Upon completion, the child nodes of the PLIST_DICT node are detached from the original node and freed, however the data of the child nodes - the key string and the uint value - are not. This commit fixes it. | |||||
2016-06-29 | plist_data_compare: Make sure to compare the node sizes for integer nodes | Nikias Bassen | 1 | -0/+2 | |
Without this check, e.g. the values -1 and 18446744073709551615 would yield in a match, since the comparison will just compare the uint64_t values. However, any value >= 9223372036854775808 and <= 18446744073709551615 is stored as a 128 bit value in binary plist format to make sure it is recognized as an unsigned value. We store it internally as a uint64_t value, but we set the size to 16 vs. 8 accordingly; so this commit will make sure the binary plist optimization will not re-use matching uint64_t values of actually mismatching signed/unsigned values. | |||||
2016-05-12 | Implement plist_from_memory() | Christophe Fergeau | 1 | -0/+15 | |
Rather than having everyone reimplement binary/XML plist detection by looking at the first bytes of the plist content, it's better to do this detection in libplist and hide that internal detail from library users. |