From ed4c858c5f37113f498fe6e85366ae38a0f29a9d Mon Sep 17 00:00:00 2001 From: Nikias Bassen Date: Wed, 11 Jan 2012 15:26:44 +0100 Subject: node_list: Fix memory corruption The corruption occured if you removed the last node from the list and later add a new node to the list. --- libcnary/node_list.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libcnary/node_list.c b/libcnary/node_list.c index 2a9cf90..78f450e 100644 --- a/libcnary/node_list.c +++ b/libcnary/node_list.c @@ -59,7 +59,10 @@ int node_list_add(node_list_t* list, node_t* node) { node->prev = last; // Set the next element of our old "last" element - last->next = node; + if (last) { + // but only if the node list is not empty + last->next = node; + } // Set the lists prev to the new last element list->end = node; @@ -129,6 +132,9 @@ int node_list_remove(node_list_t* list, node_t* node) { node->prev->next = newnode; if (newnode) { newnode->prev = node->prev; + } else { + // last element in the list + list->end = node->prev; } } else { // we just removed the first element -- cgit v1.1-32-gdbae