From 8d30a559cf0585625d9d05dc8ce0dd495b1de4f4 Mon Sep 17 00:00:00 2001 From: Nikias Bassen Date: Wed, 21 Jun 2023 00:12:04 +0200 Subject: Remove unneeded buffer copy in device_info_from_plist() --- src/libusbmuxd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/libusbmuxd.c b/src/libusbmuxd.c index cfb34a2..95e322f 100644 --- a/src/libusbmuxd.c +++ b/src/libusbmuxd.c @@ -282,13 +282,11 @@ static usbmuxd_device_info_t *device_info_from_plist(plist_t props) devinfo->conn_type = CONNECTION_TYPE_NETWORK; n = plist_dict_get_item(props, "NetworkAddress"); if (n && plist_get_node_type(n) == PLIST_DATA) { - char *netaddr = NULL; uint64_t addr_len = 0; - plist_get_data_val(n, &netaddr, &addr_len); + const char *netaddr = plist_get_data_ptr(n, &addr_len); if (netaddr && addr_len > 0 && addr_len < sizeof(devinfo->conn_data)) { memcpy(devinfo->conn_data, netaddr, addr_len); } - free(netaddr); } } else { LIBUSBMUXD_ERROR("%s: Unexpected ConnectionType '%s'\n", __func__, strval); -- cgit v1.1-32-gdbae