summaryrefslogtreecommitdiffstats
path: root/src/dfu.c
diff options
context:
space:
mode:
authorGravatar BALATON Zoltan2017-02-09 00:37:06 +0100
committerGravatar BALATON Zoltan2017-11-13 22:12:44 +0100
commita87ce4efcbdb9ad3aff3eb52ee9fd9da8e4ab922 (patch)
tree78dba41813b8037db98212a8647ec4bf940b2fc7 /src/dfu.c
parent08d610d5811ed0aa3fecf48ff9e9cee2190b1981 (diff)
downloadidevicerestore-a87ce4efcbdb9ad3aff3eb52ee9fd9da8e4ab922.tar.gz
idevicerestore-a87ce4efcbdb9ad3aff3eb52ee9fd9da8e4ab922.tar.bz2
Change check_hardware_model() to get_irecv_device()
The check_hardware_model() function has a misleading name. It returns a string with the hardware model but this is not used. Instead, this function is only called for its side effect to initialise an irecv device in the passed client struct which it creates from the hardware model name returned by mode specific implementations. But these mode specific implementations already create an irecv device to get the hardware model name so instead of going through this unnecessary complication just return the irecv device directly and rename the function accordingly to make this clear. (This may also prevent leaking an irecv device in the mode specific functions.)
Diffstat (limited to 'src/dfu.c')
-rw-r--r--src/dfu.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/dfu.c b/src/dfu.c
index 124d2c7..11aa843 100644
--- a/src/dfu.c
+++ b/src/dfu.c
@@ -109,7 +109,7 @@ int dfu_check_mode(struct idevicerestore_client_t* client, int* mode) {
return 0;
}
-const char* dfu_check_hardware_model(struct idevicerestore_client_t* client) {
+irecv_device_t dfu_get_irecv_device(struct idevicerestore_client_t* client) {
irecv_client_t dfu = NULL;
irecv_error_t dfu_error = IRECV_E_SUCCESS;
irecv_device_t device = NULL;
@@ -125,7 +125,7 @@ const char* dfu_check_hardware_model(struct idevicerestore_client_t* client) {
return NULL;
}
- return device->hardware_model;
+ return device;
}
int dfu_send_buffer(struct idevicerestore_client_t* client, unsigned char* buffer, unsigned int size)