Improve type safety of new logging system and its handling of varargs

- Replaced loglevel arguments and globals using the `int` type with the `loglevel` enum.
- Moved logging print func handler function declaration to typedef.
- Fixed misuse of `print_func` where a char* was passed in place of `va_list` via a wrapper function `print_funcf`.
- Fixed reuse of varargs in `logger` causing a segfault when `stderr_enabled` is true.
- Fixed length in `snprintf` call inside `logger_hex_dump` truncating the printed text.

1 files changed, 4 insertions, 2 deletions

diff --git a/src/log.h b/src/log.h
index 80642c0..ad3da14 100644
--- a/src/log.h
+++ b/src/log.h
@@ -30,11 +30,13 @@ enum loglevel {
 	LL_DEBUG
 };
 
-extern int log_level;
+extern enum loglevel log_level;
+
+typedef void (*logger_print_func)(enum loglevel level, const char*, va_list);
 
 void logger(enum loglevel level, const char *fmt, ...) __attribute__ ((format (printf, 2, 3)));
 int logger_set_logfile(const char* path);
-void logger_set_print_func(void (*func)(int level, const char*, va_list));
+void logger_set_print_func(logger_print_func func);
 void logger_dump_hex(enum loglevel level, const void* buf, unsigned int len);
 void logger_dump_plist(enum loglevel level, plist_t plist, int human_readable);