diff options
author | Rosen Penev | 2020-12-23 17:39:01 -0800 |
---|---|---|
committer | Nikias Bassen | 2022-04-30 13:34:21 +0200 |
commit | cf2c7d48380969200034afeab93169e68c34c397 (patch) | |
tree | a96f518be279922d00898a3ce81dc0ff483a40b2 /src/restore.c | |
parent | 6cb13f9e6d3939930aecf91d8e23d1896a3b92e5 (diff) | |
download | libimobiledevice-cf2c7d48380969200034afeab93169e68c34c397.tar.gz libimobiledevice-cf2c7d48380969200034afeab93169e68c34c397.tar.bz2 |
[clang-tidy] Do not use else after return
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Diffstat (limited to 'src/restore.c')
-rw-r--r-- | src/restore.c | 18 |
1 files changed, 8 insertions, 10 deletions
diff --git a/src/restore.c b/src/restore.c index 4e9d65a..591fd16 100644 --- a/src/restore.c +++ b/src/restore.c @@ -268,29 +268,27 @@ LIBIMOBILEDEVICE_API restored_error_t restored_query_value(restored_client_t cli LIBIMOBILEDEVICE_API restored_error_t restored_get_value(restored_client_t client, const char *key, plist_t *value) { + plist_t item; + if (!client || !value || (value && *value)) return RESTORE_E_INVALID_ARG; if (!client->info) return RESTORE_E_NOT_ENOUGH_DATA; - restored_error_t ret = RESTORE_E_SUCCESS; - plist_t item = NULL; - if (!key) { *value = plist_copy(client->info); return RESTORE_E_SUCCESS; - } else { - item = plist_dict_get_item(client->info, key); } - if (item) { - *value = plist_copy(item); - } else { - ret = RESTORE_E_PLIST_ERROR; + item = plist_dict_get_item(client->info, key); + if (!item) { + return RESTORE_E_PLIST_ERROR; } - return ret; + *value = plist_copy(item); + free(item); + return RESTORE_E_SUCCESS; } LIBIMOBILEDEVICE_API restored_error_t restored_client_new(idevice_t device, restored_client_t *client, const char *label) |