summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGravatar Rosen Penev2020-06-03 15:50:19 -0700
committerGravatar Nikias Bassen2020-12-30 02:54:57 +0100
commit22988d874570c35251076f9edc1cd3c99ecb6785 (patch)
tree725a1119380e8745aa92d1ae53ce627c337410c5
parente7168f30e6fdf0a1f9cffdc9252f52d45e5a59ef (diff)
downloadlibusbmuxd-22988d874570c35251076f9edc1cd3c99ecb6785.tar.gz
libusbmuxd-22988d874570c35251076f9edc1cd3c99ecb6785.tar.bz2
Add parentheses to macro arguments
[clang-tidy] Found with bugprone-macro-parentheses Signed-off-by: Rosen Penev <rosenp@gmail.com>
-rw-r--r--common/collection.c2
-rw-r--r--tools/iproxy.c6
2 files changed, 4 insertions, 4 deletions
diff --git a/common/collection.c b/common/collection.c
index 92bd645..8a2fe72 100644
--- a/common/collection.c
+++ b/common/collection.c
@@ -31,7 +31,7 @@
#undef NDEBUG // we need to make sure we still get assertions because we can't handle memory allocation errors
#include <assert.h>
-#define INIT_NULL(addr, count) { unsigned int i_ = 0; for (i_ = 0; i_ < count; i_++) ((void**)addr)[i_] = NULL; }
+#define INIT_NULL(addr, count) { unsigned int i_ = 0; for (i_ = 0; i_ < (count); i_++) ((void**)(addr))[i_] = NULL; }
#define CAPACITY_STEP 8
diff --git a/tools/iproxy.c b/tools/iproxy.c
index 5dca580..bd56ebd 100644
--- a/tools/iproxy.c
+++ b/tools/iproxy.c
@@ -68,9 +68,9 @@ struct client_data {
};
#define CDATA_FREE(x) if (x) { \
- if (x->fd > 0) socket_close(x->fd); \
- if (x->sfd > 0) socket_close(x->sfd); \
- free(x->udid); \
+ if ((x)->fd > 0) socket_close((x)->fd); \
+ if ((x)->sfd > 0) socket_close((x)->sfd); \
+ free((x)->udid); \
free(x); \
}